-
Notifications
You must be signed in to change notification settings - Fork 14k
docs: split a run-on sentence #29442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/compiler-rt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a mistake!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, I have no idea how that happened. Sorry, I'll be more careful in the future, and will fix this right now…
This is two sentences that have been comma spliced, and should be split with a full stop. (This error made me stop and re-read, and I submit this as an actual improvement to readability, not as a grammar weird-o!)
|
I've removed a mistaken commit to a submodule, leaving only the intended change. |
|
it's all good, it happens all the time. Thanks again for the patch! |
|
@bors: r+ rollup |
|
📌 Commit 618d226 has been approved by |
This is two sentences that have been comma spliced, and should be split with a full stop. (This error made me stop and re-read, and I submit this as an actual improvement to readability, not as a grammar weird-o!)
This is two sentences that have been comma spliced, and should
be split with a full stop. (This error made me stop and re-read,
and I submit this as an actual improvement to readability, not
as a grammar weird-o!)