Rollup of 9 pull requests #34500
Closed
Rollup of 9 pull requests #34500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indicate how it gets created and add an example.
… r=steveklabnik Syntax coloring and more compact diagram Two cosmetic improvements: - New content was added a few days ago to the **Closures** chapter but it was missing rust's syntax coloring. - Also, in the **Crates and Modules** chapter, a diagram was improved to be more symmetric and to take less space.
update reference for rust-lang#29734
Traits where syntax's extra usage example more clearly r? @steveklabnik
Add example for `std::thread::sleep`. None
…teveklabnik [doc] Fix links in Ownership section of the book - Add a missing link definition for `[i32]`. - Like `[stack]` link is pointing to `...#the-stack`, append `#the-heap` to `[heap]` link.
…Gomez Add example with leading zeros I was searching for this format very long. So I added an example to the prominent section. I was thinking of putting the keyword leading in the corresponding section as well, what do you think? r? @steveklabnik
…bnik Fix E0269 error explanation r? @steveklabnik
…eGomez Expand `std::path::Component` documentation. Indicate how it gets created and add an example.
…st, r=GuillaumeGomez rustdoc: Fix inlined renamed reexports in import lists Fixes rust-lang#34473
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 2cbb1b6 has been approved by |
|
You should remove bbc33ac from the rollup; it's currently failing (see the associated PR). |
|
⌛ Testing commit 2cbb1b6 with merge 01728b1... |
|
@bors: r- force |
|
⛄ The build was interrupted to prioritize another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::thread::sleep. #34406, [doc] Fix links in Ownership section of the book #34442, Add example with leading zeros #34462, Fix E0269 error explanation #34471, Expandstd::path::Componentdocumentation. #34475, rustdoc: Fix inlined renamed reexports in import lists #34479