Methods Fn(Mut,Once)::call(mut,once) are gated with two feature gates, remove one of them
#34802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems fine. I was a little concerned about whether it was okay to remove a feature gate like this without consulting the language team, but it seems that in all cases where an actual feature was/is being properly gated, it continues to be gated (by some other feature gate). @eddyb has pointed out that the |
|
☔ The latest upstream changes (presumably #34485) made this pull request unmergeable. Please resolve the merge conflicts. |
…ed_closures` They are already gated with feature `fn_traits`
|
Rebased. |
|
@bors r+ rollup |
|
📌 Commit a80d329 has been approved by |
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Aug 1, 2016
Methods `Fn(Mut,Once)::call(mut,once)` are gated with two feature gates, remove one of them Methods `Fn::call`, `FnMut::call_mut` and `FnOnce::call_once` are gated with usual library feature `fn_traits` and also hardcoded in the compiler and gated once more with feature `unboxed_closures` This patch removes the `unboxed_closures`feature gate from these methods (`unboxed_closures` is still used for other things though), now they are gated only with `fn_traits`. All unnecessary `#![feature(unboxed_closures)]`s are removed, many of them are old and were already unnecessary before the change this PR does.
bors
added a commit
that referenced
this pull request
Aug 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Methods
Fn::call,FnMut::call_mutandFnOnce::call_onceare gated with usual library featurefn_traitsand also hardcoded in the compiler and gated once more with featureunboxed_closuresThis patch removes the
unboxed_closuresfeature gate from these methods (unboxed_closuresis still used for other things though), now they are gated only withfn_traits.All unnecessary
#![feature(unboxed_closures)]s are removed, many of them are old and were already unnecessary before the change this PR does.