syntax: Remove traits AttrMetaMethods, AttributeMethods, and AttrNestedMetaItemMethods
#35917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cgswords @eddyb |
jseyfried
force-pushed
the
remove_attr_ext_traits
branch
from
e690edc to
a290269
Compare
jseyfried
force-pushed
the
remove_attr_ext_traits
branch
from
a290269 to
af064ec
Compare
|
☔ The latest upstream changes (presumably #35854) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r+ |
jseyfried
force-pushed
the
remove_attr_ext_traits
branch
from
af064ec to
3e5494c
Compare
|
☔ The latest upstream changes (presumably #35764) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
force-pushed
the
remove_attr_ext_traits
branch
2 times, most recently
from
2534cfc to
fa9aedb
Compare
|
Rebased. |
|
☔ The latest upstream changes (presumably #35979) made this pull request unmergeable. Please resolve the merge conflicts. |
jseyfried
force-pushed
the
remove_attr_ext_traits
branch
from
fa9aedb to
469753f
Compare
jseyfried
changed the title
AttrMetaMethods, AttributeMethods, and AttrMetaListItemMethodsAttrMetaMethods, AttributeMethods, and AttrNestedMetaItemMethods
|
Rebased. |
jseyfried
added a commit
to jseyfried/rust
that referenced
this pull request
Aug 28, 2016
…=nrc syntax: Remove traits `AttrMetaMethods`, `AttributeMethods`, and `AttrNestedMetaItemMethods`
bors
added a commit
that referenced
this pull request
Aug 30, 2016
Batch up libsyntax breaking changes Batch of the following syntax-[breaking-change] changes: - #35591: Add a field `span: Span` to `ast::Generics`. - #35618: Remove variant `Mod` of `ast::PathListItemKind` and refactor the remaining variant `ast::PathListKind::Ident` to a struct `ast::PathListKind_`. - #35480: Change uses of `Constness` in the AST to `Spanned<Constness>`. - c.f. `MethodSig`, `ItemKind` - #35728: Refactor `cx.pat_enum()` into `cx.pat_tuple_struct()` and `cx.pat_path()`. - #35850: Generalize the elements of lists in attributes from `MetaItem` to a new type `NestedMetaItem` that can represent a `MetaItem` or a literal. - #35917: Remove traits `AttrMetaMethods`, `AttributeMethods`, and `AttrNestedMetaItemMethods`. - Besides removing imports of these traits, this won't cause fallout. - Add a variant `Union` to `ItemKind` to future proof for `union` (c.f. #36016). - Remove inherent methods `attrs` and `fold_attrs` of `Annotatable`. - Use methods `attrs` and `map_attrs` of `HasAttrs` instead. r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax-[breaking-change] cc #31645
r? @nrc