Implement Debug for std::path::{Components,Iter}.

[frewsxcv]

No description provided.

[Stebalien]

It's a shame to have to allocate on debug. You should be able to do this using debug_list and a helper struct.

[frewsxcv]

Yeah, I can switch this to debug_list to avoid the allocation, though we lose the "Components" title. I wonder if there is value in adding a debug_iter that offers name and iterator params.

[Stebalien]

Make a helper struct that implements debug and outputs [...]. That is,

f.debug_tuple("Components").field(&DebugHelper(self)).finish();

where DebugHelper implements Debug.

[alexcrichton]

Thanks @frewsxcv! I wonder if perhaps the same implementation should be used for the other iterators in this module?

[frewsxcv]

Latest commits no longer allocate Vecs. I also implemented Debug for std::path::Iter.

[alexcrichton]

This since should be 1.13.0 I believe

[frewsxcv]

Addressed in the latest force push.

[alexcrichton]

@bors: r+ e118d4c

[sophiajt]

@bors rollup

[sophiajt]

@bors r-

I'm seeing this failure on build_bot (auto-win-msvc-64-opt-rustbuild), and it seems related:

failures:
    path::tests::test_iter_debug

test result: FAILED. 736 passed; 1 failed; 4 ignored; 0 measured

If that's not related I can re-approve.

[frewsxcv]

More info:

thread '<unnamed>' panicked at 'assertion failed: `(left == right)` (left: `"Iter([\"/\", \"tmp\"])"`, right: `"Iter([\"\\\\\", \"tmp\"])"`)', C:\bot\slave\auto-win-msvc-64-opt-rustbuild\build\src\libstd\path.rs:3554

I changed that test to only run on unix now.

[alexcrichton]

@bors: r+

[bors]

📌 Commit 268b3f5 has been approved by alexcrichton