Skip to content

Conversation

@pftbest
Copy link
Contributor

@pftbest pftbest commented Dec 8, 2016

Fixes #37829

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@japaric
Copy link
Contributor

japaric commented Dec 8, 2016

Thanks, @pftbest!

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2016

📌 Commit 59a5254 has been approved by japaric

@japaric japaric assigned japaric and unassigned nikomatsakis Dec 8, 2016
@pftbest
Copy link
Contributor Author

pftbest commented Dec 8, 2016

Why did it fail checks? Is there something wrong with PR?

@japaric
Copy link
Contributor

japaric commented Dec 8, 2016

Is there something wrong with PR?

No AFAICT

Why did it fail checks?

That particular Travis build job has been failing in several other PRs though I don't know why. It's a false alarm.

@pftbest
Copy link
Contributor Author

pftbest commented Dec 8, 2016

@japaric
good to know, thanks!

@bors
Copy link
Collaborator

bors commented Dec 11, 2016

⌛ Testing commit 59a5254 with merge ea79852...

bors added a commit that referenced this pull request Dec 11, 2016
LLVM: Update submodule to include patches for MSP430.

Fixes #37829
@bors bors merged commit 59a5254 into rust-lang:master Dec 11, 2016
@pftbest pftbest deleted the update_llvm branch December 11, 2016 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants