Skip to content

Overhaul Bootstrap (x.py) Command-Line-Parsing & Help Output #41011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 6, 2017
Merged

Overhaul Bootstrap (x.py) Command-Line-Parsing & Help Output #41011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e1b0027
Refer to a subcommand as a subcommand.
CleanCut Mar 31, 2017
8ad5c95
When dealing with the list of all possible subcommands, deal with the…
CleanCut Mar 31, 2017
e1c1e09
Don't print build statistics if we explicitly asked for the help mess…
CleanCut Mar 31, 2017
584b405
Vastly improve the help output.
CleanCut Mar 31, 2017
992a59e
Using an untyped, one-letter variable binding as an argument to a fun…
CleanCut Mar 31, 2017
5ba579e
Save my TODO's as comments, so I don't forget.
CleanCut Mar 31, 2017
aa4bd0e
Finish the improvements I planned.
CleanCut Apr 1, 2017
2c9ae48
Oops, we can't parse options until all options have been defined. Ti…
CleanCut Apr 2, 2017
6b72586
Simplify a "use" statement as per @grunweg's feedback.
CleanCut Apr 2, 2017
1e53898
Fix breaking the 'clean' subcommand caused replacing a single-letter …
CleanCut Apr 2, 2017
20cb700
Handle options-with-arguments before subcommands such as './x.py -j 1…
CleanCut Apr 4, 2017
ea2bfae
Branch arms need to match the return value even if it's not being ass…
CleanCut Apr 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/bootstrap/bootstrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,16 +591,19 @@ def bootstrap():

def main():
start_time = time()
help_triggered = ('-h' in sys.argv) or ('--help' in sys.argv) or (len(sys.argv) == 1)
try:
bootstrap()
print("Build completed successfully in %s" % format_build_time(time() - start_time))
if not help_triggered:
print("Build completed successfully in %s" % format_build_time(time() - start_time))
except (SystemExit, KeyboardInterrupt) as e:
if hasattr(e, 'code') and isinstance(e.code, int):
exit_code = e.code
else:
exit_code = 1
print(e)
print("Build completed unsuccessfully in %s" % format_build_time(time() - start_time))
if not help_triggered:
print("Build completed unsuccessfully in %s" % format_build_time(time() - start_time))
sys.exit(exit_code)

if __name__ == '__main__':
Expand Down
Loading