Print out a more helpful type error message for do-blocks/for-loops #4141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a do-block body has the wrong type, or a for-loop body has a non-() type, suggest that the user might have meant the other one. As per rust-lang#2817
|
r+, though I'd like to know your thoughts about the criteria for the check. |
|
Sure, that seems reasonable. I was trying to not do any more than I was testing for. I changed the check, added a few more test cases, and merged it. |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jan 19, 2025
Automatic Rustup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a do-block body has the wrong type, or a for-loop body has a
non-() type, suggest that the user might have meant the other one.
As per #2817
r? @brson