Skip to content

Conversation

@QuietMisdreavus
Copy link
Contributor

Fixes #25264

image

@rust-highfive
Copy link
Contributor

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

Iiinteresting. I like it, would like to see what others say.

@QuietMisdreavus
Copy link
Contributor Author

I guess we should properly tag @rust-lang/docs to pull in the others, in that case.

@GuillaumeGomez
Copy link
Member

Wo, that's awesome! Huge 👍 for me!

@steveklabnik
Copy link
Contributor

@bors: r+

everyone is happy with this!

@bors
Copy link
Collaborator

bors commented Oct 11, 2017

📌 Commit 23f5fbe has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Oct 12, 2017

⌛ Testing commit 23f5fbe with merge fbb5054...

bors added a commit that referenced this pull request Oct 12, 2017
@bors
Copy link
Collaborator

bors commented Oct 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing fbb5054 to master...

@bors bors merged commit 23f5fbe into rust-lang:master Oct 12, 2017
@QuietMisdreavus QuietMisdreavus deleted the impls-for-everyone branch February 26, 2018 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants