Deploy builds both with asserts enabled and asserts disabled to CI. #46354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes uploads to the 'try' bucket, and instead dumps everything into the two rustc-builds and rustc-builds-alt buckets. This makes lives easier, as there is only one location for a given "type" of build, and since we have the git commit hash in the filenames, this is fine; we won't run into uploads of the same commit.
|
@eddyb I think once this lands you can rebase and re-run try and it should work |
Mark-Simulacrum
added
the
T-infra
|
@bors: r+ |
|
📌 Commit 2485afa has been approved by |
|
⌛ Testing commit 2485afa with merge 674fa1053d7ffd440f84bfc6851df9da5c931780... |
|
💔 Test failed - status-travis |
|
@bors retry — travis-ci/travis-ci#8821 |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 29, 2017
…hton Deploy builds both with asserts enabled and asserts disabled to CI. This also removes uploads to the 'try' bucket, and instead dumps everything into the two rustc-builds and rustc-builds-alt buckets. This makes lives easier, as there is only one location for a given "type" of build, and since we have the git commit hash in the filenames, this is fine; we won't run into uploads of the same commit. cc @aidanhs -- this will break crater's logic for downloading `try#xxx` commits since the try bucket won't be uploaded into r? @alexcrichton
kennytm
added
the
S-waiting-on-bors
Closed
aidanhs
added a commit
to aidanhs/crater
that referenced
this pull request
Dec 11, 2017
aidanhs
added a commit
to aidanhs/crater
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes uploads to the 'try' bucket, and instead dumps
everything into the two rustc-builds and rustc-builds-alt buckets. This
makes lives easier, as there is only one location for a given "type" of
build, and since we have the git commit hash in the filenames, this is
fine; we won't run into uploads of the same commit.
cc @aidanhs -- this will break crater's logic for downloading
try#xxxcommits since the try bucket won't be uploaded intor? @alexcrichton