Skip to content

Remove Sync and Send implementation for RawTable #46710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove Sync and Send implementation for RawTable #46710

wants to merge 1 commit into from

Conversation

@sugar700
Copy link
Contributor

@sugar700 sugar700 commented Dec 13, 2017

The implementation was introduced when changing hash storage from Unique to *mut, but it was changed back to Unique.

@sugar700
Remove Sync and Send implementation for RawTable
524c3ff 
The implementation was introduced when changing hash storage from
Unique to *mut, but it was changed back to Unique.
@rust-highfive
Copy link
Contributor

rust-highfive commented Dec 13, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

alexcrichton commented Dec 13, 2017

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Dec 13, 2017

📌 Commit 524c3ff has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Dec 13, 2017

🌲 The tree is currently closed for pull requests below priority 2, this pull request will be tested once the tree is reopened

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 13, 2017
@kennytm
Copy link
Member

kennytm commented Dec 14, 2017

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Dec 15, 2017
@steveklabnik
Rollup merge of rust-lang#46710 - xfix:patch-5, r=alexcrichton
710e32a 
Remove Sync and Send implementation for RawTable

The implementation was introduced when changing hash storage from Unique to *mut, but it was changed back to Unique.
@steveklabnik steveklabnik mentioned this pull request Dec 15, 2017
Merged
bors added a commit that referenced this pull request Dec 15, 2017
@bors
Auto merge of #46745 - steveklabnik:rollup, r=steveklabnik
50f6c3e 
Rollup of 7 pull requests

- Successful merges: #46601, #46652, #46690, #46705, #46710, #46728, #46737
- Failed merges:
@bors
Copy link
Collaborator

bors commented Dec 15, 2017

☔ The latest upstream changes (presumably #46745) made this pull request unmergeable. Please resolve the merge conflicts.

@kennytm
Copy link
Member

kennytm commented Dec 15, 2017

This has been merged as part of #46745.

@kennytm kennytm closed this Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sugar700 @rust-highfive @alexcrichton @bors @kennytm