Skip to content

Fix ICE by disallowing impl Trait in unsupported position #49830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2018
Merged

Fix ICE by disallowing impl Trait in unsupported position #49830

merged 1 commit into from
Apr 13, 2018

Conversation

sinkuu
Copy link
Contributor

@sinkuu sinkuu commented Apr 10, 2018

Fixes #47715.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 10, 2018
@eddyb
Copy link
Member

eddyb commented Apr 10, 2018

LGTM. r? @cramertj

@rust-highfive rust-highfive assigned cramertj and unassigned eddyb Apr 10, 2018
@cramertj
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Apr 10, 2018

📌 Commit 378bd49 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2018
@sinkuu
Copy link
Contributor Author

sinkuu commented Apr 11, 2018

Can this (and #49730) be beta-nominated per #34511 (comment)?

@cramertj cramertj added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 11, 2018
@sinkuu sinkuu mentioned this pull request Apr 13, 2018
Closed
@kennytm
Copy link
Member

kennytm commented Apr 13, 2018

@bors p=4

@bors
Copy link
Collaborator

bors commented Apr 13, 2018

⌛ Testing commit 378bd49 with merge 7291829...

bors added a commit that referenced this pull request Apr 13, 2018
@bors
Auto merge of #49830 - sinkuu:fix_ice_47715, r=cramertj
7291829 
Fix ICE by disallowing `impl Trait` in unsupported position

Fixes #47715.
@bors
Copy link
Collaborator

bors commented Apr 13, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: cramertj
Pushing 7291829 to master...

@bors bors merged commit 378bd49 into rust-lang:master Apr 13, 2018
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 20, 2018
@alexcrichton alexcrichton mentioned this pull request Apr 20, 2018
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2018
bors added a commit that referenced this pull request Apr 21, 2018
@bors
Auto merge of #50127 - alexcrichton:beta-next2, r=alexcrichton
9b97d1e 
[beta] Processing merged backports

This is a backport of the following PRs:

* #49386
* #49465
* #49647
* #49692
* #49695
* #49714
* #49730
* #49830
* #49981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cramertj cramertj

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sinkuu @rust-highfive @eddyb @cramertj @bors @kennytm @alexcrichton