Skip to content

[beta] backport various PRs #50027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 19, 2018
Merged

[beta] backport various PRs #50027

merged 16 commits into from
Apr 19, 2018

Conversation

@oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 17, 2018 •
edited by kennytm
Loading

original PRs:

@rust-highfive
Copy link
Contributor

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2018
@kennytm kennytm mentioned this pull request Apr 17, 2018
Closed
@oli-obk oli-obk force-pushed the const_signed_pat_beta branch from eb81410 to 7e2aada Compare April 17, 2018 17:30
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 17, 2018

r? @kennytm

all merged into one now

@rust-highfive rust-highfive assigned kennytm and unassigned eddyb Apr 17, 2018
@oli-obk oli-obk changed the title [beta] Sign extend constants in range patterns [beta] backport various PRs Apr 17, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 17, 2018

cc @rust-lang/compiler a beta backport of the various fixes for miri+incremental ICEs

@kennytm
Copy link
Member

kennytm commented Apr 17, 2018

@bors r+ p=4

@bors
Copy link
Collaborator

bors commented Apr 17, 2018

📌 Commit 7e2aada has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2018
@kennytm
Copy link
Member

kennytm commented Apr 17, 2018

@bors r-

Err wait, let's ensure that #49949 is successfully merged first.

Also, #49949, #49947 and #49833 are missing the beta-accepted labels for rubber-stamping the backport.

@pietroalbini pietroalbini mentioned this pull request Apr 17, 2018
Closed
2 tasks
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2018
@kennytm
Copy link
Member

kennytm commented Apr 19, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 19, 2018

📌 Commit 7e2aada has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Apr 19, 2018
@oli-obk
Copy link
Contributor Author

oli-obk commented Apr 19, 2018

we don't have rubber stamps yet...

@bors
Copy link
Collaborator

bors commented Apr 19, 2018

⌛ Testing commit 7e2aada with merge 8d3e0c17b09936d52c8696e86e53bd44fe83f7db...

@nagisa
Copy link
Member

nagisa commented Apr 19, 2018 via email

@bors
Copy link
Collaborator

bors commented Apr 19, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2018
@pietroalbini
Copy link
Member

Timed out on Travis IMAGE=x86_64-gnu-incremental.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2018
@kennytm
Copy link
Member

kennytm commented Apr 19, 2018

@bors r+

Rolled up #50046 here.

@bors
Copy link
Collaborator

bors commented Apr 19, 2018

📌 Commit 0f4bb2f has been approved by kennytm

@kennytm
Copy link
Member

kennytm commented Apr 19, 2018

@bors p=5

@bors
Copy link
Collaborator

bors commented Apr 19, 2018

⌛ Testing commit 0f4bb2f with merge 8423230...

bors added a commit that referenced this pull request Apr 19, 2018
@bors
Auto merge of #50027 - oli-obk:const_signed_pat_beta, r=kennytm
8423230 
[beta] backport various PRs

original PRs:

* #49949 (not yet merged at the time of writing)
* #49947 (long running const eval error -> warning)
* #49833 (static recursion)
* #49876 (no clippy in stable rls)
* #49904 (Work around LLVM debuginfo problem in librustc_driver. )
@bors
Copy link
Collaborator

bors commented Apr 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 8423230 to beta...

@bors bors merged commit 0f4bb2f into rust-lang:beta Apr 19, 2018
This was referenced Apr 20, 2018
Merged
Merged
Merged
@oli-obk oli-obk deleted the const_signed_pat_beta branch April 23, 2018 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eddyb eddyb eddyb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kennytm kennytm

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@oli-obk @rust-highfive @kennytm @bors @nagisa @pietroalbini @eddyb @michaelwoerister