Stablize Iterator::find_map #53385
Merged
Stablize Iterator::find_map #53385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
matklad
force-pushed
the
stabilize-find-map
branch
from
3f6a776 to
c6a93aa
Compare
kennytm
added
relnotes
Member
|
This PR is blocked by the FCP happening on the tracking issue which will complete in 8 days. |
kennytm
reviewed
Aug 15, 2018
src/libcore/iter/iterator.rs
Outdated
Contributor
Author
There was a problem hiding this comment.
Lol, I specifically looked at flatten for the since format, and it dropped the trailing zero. Should i change
#[stable(feature = "iterator_flatten", since = "1.29")]
fn flatten(self) -> Flatten<Self>
where Self: Sized, Self::Item: IntoIterator {
to
#[stable(feature = "iterator_flatten", since = "1.29.0")]
fn flatten(self) -> Flatten<Self>
where Self: Sized, Self::Item: IntoIterator {
in this PR?
Member
There was a problem hiding this comment.
@matklad As you like 😂. Perhaps we need a tidy check to ensure the since is a valid semver.
matklad
force-pushed
the
stabilize-find-map
branch
from
c6a93aa to
70a2b79
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
matklad
force-pushed
the
stabilize-find-map
branch
from
70a2b79 to
057878a
Compare
Contributor
Author
|
Ok, looks like one does not simply change the |
Member
|
@matklad if you wanna change to 1.29.0, it needs to be applied all instances of |
Contributor
|
Alrighty, the FCP is now completed so we can start moving this forward. |
Contributor
Author
|
This is ready for r+, yeah! The version number problem for flatten has beenhandled in a separate PR. |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 057878a has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Aug 25, 2018
Stablize Iterator::find_map Stabilization PR for #49602
Member
|
@bors rollup |
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilization PR for #49602