Slimmer syntax #68133
Merged
Slimmer syntax #68133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 11, 2020
…lacrum Move more of `rustc::lint` into `rustc_lint` Based on rust-lang#67806. Here we try to consolidate more of the linting infra into `rustc::lint`. Some high-level notes: - We now store an `Lrc<dyn Any + Send + Sync>` as opposed to `Lrc<LintStore>` in the `GlobalCtxt`. This enables us to avoid referring to the type, breaking a cyclic dependency, and so we can move things from `rustc::lint` to `rustc_lint`. - `in_derive_expansion` is, and needs to, be moved as a method on `Span`. - We reduce the number of ways on `tcx` to emit a lint so that the developer UX is more streamlined. - `LintLevelsBuilder` is moved to `rustc_lint::levels`, leaving behind `LintLevelMap/Set` in a purified form due to current constraints (hopefully fixable in the future after rust-lang#68133). - `struct_lint_level` is moved to `rustc::lint` due to current dependency constraints. - `rustc::context` is moved to `rustc_lint::context`. - The visitors in `rustc::lint` are moved to `rustc_lint::passes`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jan 11, 2020
…lacrum Move more of `rustc::lint` into `rustc_lint` Based on rust-lang#67806. Here we try to consolidate more of the linting infra into `rustc::lint`. Some high-level notes: - We now store an `Lrc<dyn Any + Send + Sync>` as opposed to `Lrc<LintStore>` in the `GlobalCtxt`. This enables us to avoid referring to the type, breaking a cyclic dependency, and so we can move things from `rustc::lint` to `rustc_lint`. - `in_derive_expansion` is, and needs to, be moved as a method on `Span`. - We reduce the number of ways on `tcx` to emit a lint so that the developer UX is more streamlined. - `LintLevelsBuilder` is moved to `rustc_lint::levels`, leaving behind `LintLevelMap/Set` in a purified form due to current constraints (hopefully fixable in the future after rust-lang#68133). - `struct_lint_level` is moved to `rustc::lint` due to current dependency constraints. - `rustc::lint::context` is moved to `rustc_lint::context`. - The visitors in `rustc::lint` are moved to `rustc_lint::passes`.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jan 12, 2020
…lacrum Move more of `rustc::lint` into `rustc_lint` Based on rust-lang#67806. Here we try to consolidate more of the linting infra into `rustc::lint`. Some high-level notes: - We now store an `Lrc<dyn Any + Send + Sync>` as opposed to `Lrc<LintStore>` in the `GlobalCtxt`. This enables us to avoid referring to the type, breaking a cyclic dependency, and so we can move things from `rustc::lint` to `rustc_lint`. - `in_derive_expansion` is, and needs to, be moved as a method on `Span`. - We reduce the number of ways on `tcx` to emit a lint so that the developer UX is more streamlined. - `LintLevelsBuilder` is moved to `rustc_lint::levels`, leaving behind `LintLevelMap/Set` in a purified form due to current constraints (hopefully fixable in the future after rust-lang#68133). - `struct_lint_level` is moved to `rustc::lint` due to current dependency constraints. - `rustc::lint::context` is moved to `rustc_lint::context`. - The visitors in `rustc::lint` are moved to `rustc_lint::passes`.
This comment has been minimized.
This comment has been minimized.
bors
added
the
S-waiting-on-author
Centril
force-pushed
the
slimmer-syntax
branch
from
7e86477 to
d081797
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
👍 |
Cool; I'll follow up with this. :) |
Centril
force-pushed
the
slimmer-syntax
branch
from
8365081 to
279e214
Compare
Centril
added
S-waiting-on-review
|
Addressed the review comments. |
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
slimmer-syntax
branch
from
3829b30 to
1fbab97
Compare
|
@bors r+ |
|
📌 Commit 1fbab97f3d177c4f4d58f69a2b73d938740a2abc has been approved by |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
slimmer-syntax
branch
from
1fbab97 to
a67d36f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Centril
force-pushed
the
slimmer-syntax
branch
from
96d2a0a to
1a3141c
Compare
|
@bors r=petrochenkov |
|
📌 Commit 1a3141c has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 1, 2020
Slimmer syntax High-level summary of changes: - The `syntax::node_count` pass is moved into `rustc_ast_passes`. This works towards improving #65031 by making compiling `syntax` go faster. - The `syntax::{GLOBALS, with_globals, ..}` business is consolidated into `syntax::attr` for cleaner code and future possible improvements. - The pretty printer loses its dependency on `ParseSess`, opting to use `SourceMap` & friends directly instead. - Some drive by cleanup of `syntax::attr::HasAttr` happens. - Builtin attribute logic (`syntax::attr::builtin`) + `syntax::attr::allow_internal_unstable` is moved into a new `rustc_attr` crate. More logic from `syntax::attr` should be moved into that crate over time. This also means that `syntax` loses all mentions of `ParseSess`, which enables the next point. - The pretty printer `syntax::print` is moved into a new crate `rustc_ast_pretty`. - `rustc_session::node_id` is moved back as `syntax::node_id`. As a result, `syntax` gets to drop dependencies on `rustc_session` (and implicitly `rustc_target`), `rustc_error_codes`, and `rustc_errors`. Moreover `rustc_hir` gets to drop its dependency on `rustc_session` as well. At this point, these crates are mostly "pure data crates", which is approaching a desirable end state. - We should consider renaming `syntax` to `rustc_ast` now.
|
☀️ Test successful - checks-azure |
|
📣 Toolstate changed by #68133! Tested on commit 13db650. 💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 1, 2020
Tested on commit rust-lang/rust@13db650. Direct link to PR: <rust-lang/rust#68133> 💔 clippy-driver on windows: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 💔 clippy-driver on linux: test-fail → build-fail (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
This was referenced Feb 1, 2020
JohnTitor
added a commit
to JohnTitor/rust-clippy
that referenced
this pull request
Feb 1, 2020
This was referenced Feb 1, 2020
This was referenced Feb 1, 2020
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Feb 1, 2020
Rustup to rust-lang/rust#68133 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High-level summary of changes:
The
syntax::node_countpass is moved intorustc_ast_passes. This works towards improving Therustc_query_implcrate is too big, which hurts compile times for the compiler itself #65031 by making compilingsyntaxgo faster.The
syntax::{GLOBALS, with_globals, ..}business is consolidated intosyntax::attrfor cleaner code and future possible improvements.The pretty printer loses its dependency on
ParseSess, opting to useSourceMap& friends directly instead.Some drive by cleanup of
syntax::attr::HasAttrhappens.Builtin attribute logic (
syntax::attr::builtin) +syntax::attr::allow_internal_unstableis moved into a newrustc_attrcrate. More logic fromsyntax::attrshould be moved into that crate over time. This also means thatsyntaxloses all mentions ofParseSess, which enables the next point.The pretty printer
syntax::printis moved into a new craterustc_ast_pretty.rustc_session::node_idis moved back assyntax::node_id. As a result,syntaxgets to drop dependencies onrustc_session(and implicitlyrustc_target),rustc_error_codes, andrustc_errors. Moreoverrustc_hirgets to drop its dependency onrustc_sessionas well. At this point, these crates are mostly "pure data crates", which is approaching a desirable end state.syntaxtorustc_astnow.