Moving all rustdoc-ui tests to check-pass #71337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were all build-pass before and don't seem to need it. Helps with rust-lang#62277
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
What these annotations even do in rustdoc tests? |
petrochenkov
added
the
T-rustdoc
|
@petrochenkov rustdoc also has "check" runs. ;) Thanks @Valloric ! @bors: r+ |
|
📌 Commit 2add9d8 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 21, 2020
…laumeGomez Moving all rustdoc-ui tests to check-pass These were all build-pass before and don't seem to need it. Helps with rust-lang#62277 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rust-lang/rust/71337) <!-- Reviewable:end -->
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 21, 2020
…laumeGomez Moving all rustdoc-ui tests to check-pass These were all build-pass before and don't seem to need it. Helps with rust-lang#62277 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rust-lang/rust/71337) <!-- Reviewable:end -->
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#70970 (Detect mistyped associated consts in `Instance::resolve`.) - rust-lang#71203 (Correct await span for async-await error reporting) - rust-lang#71214 (Add error code for inner doc error) - rust-lang#71337 (Moving all rustdoc-ui tests to check-pass) - rust-lang#71412 (Clarify unused_doc_comments note on macro invocations) - rust-lang#71414 (More diagnostic items for Clippy usage) Failed merges: r? @ghost
jyn514
added
the
A-testsuite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were all build-pass before and don't seem to need it.
Helps with #62277
This change is