Fix ICE when lookup method in trait for type that have bound vars #80170

ldm0 · 2020-12-18T22:15:00Z

Closes #77910

rust-highfive · 2020-12-18T22:15:04Z

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

compiler/rustc_typeck/src/check/method/mod.rs

compiler/rustc_typeck/src/check/op.rs

lcnr · 2020-12-20T13:44:06Z

r? @lcnr

r=me after the nit

Co-authored-by: lcnr <[email protected]>

src/test/compile-fail/issue-77910-1.rs

lcnr · 2020-12-20T15:59:09Z

@bors r+ rollup

bors · 2020-12-20T15:59:11Z

📌 Commit ccdf58266727b97b4530e6a50992aa2559ea4be7 has been approved by lcnr

rust-log-analyzer · 2020-12-20T16:00:41Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

.................................................................................................... 400/11191
.................................................................................................... 500/11191
.........................................................i.......................................... 600/11191
...........................i........................................................................ 700/11191
..........................................................................F....F.................... 800/11191
.................................................................................................... 1000/11191
....................................i............................................................... 1100/11191
.................................................................................................... 1200/11191
.................................................................................ii.i.............i. 1300/11191
---
.................................................................................................... 9000/11191
.................................................................................................... 9100/11191
..................................................................................i......i.......... 9200/11191
.................................................................................................... 9300/11191
.....................iiiiii..iiiiii.i............................................................... 9400/11191
.................................................................................................... 9600/11191
.................................................................................................... 9700/11191
.................................................................................................... 9800/11191
.................................................................................................... 9900/11191
---
...................................................................................i................ 11100/11191
...........................................................................................
failures:

---- [ui] ui/binop/issue-77910-2.rs stdout ----
normalized stderr:
error[E0369]: binary operation `==` cannot be applied to type `for<'r> fn(&'r i32) -> &'r i32 {foo}`
  --> $DIR/issue-77910-2.rs:7:12
   |
LL |     if foo == y {}
   |        --- ^^ - _
   |        |
   |        for<'r> fn(&'r i32) -> &'r i32 {foo}
error: aborting due to previous error

For more information about this error, try `rustc --explain E0369`.




The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/issue-77910-2/issue-77910-2.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args binop/issue-77910-2.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/binop/issue-77910-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/issue-77910-2" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/issue-77910-2/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error[E0369]: binary operation `==` cannot be applied to type `for<'r> fn(&'r i32) -> &'r i32 {foo}`
  --> /checkout/src/test/ui/binop/issue-77910-2.rs:7:12
   |
LL |     if foo == y {}
   |        --- ^^ - _
   |        |
   |        for<'r> fn(&'r i32) -> &'r i32 {foo}
error: aborting due to previous error

For more information about this error, try `rustc --explain E0369`.


------------------------------------------


---- [ui] ui/binop/issue-77910-1.rs stdout ----
normalized stderr:
error[E0369]: binary operation `==` cannot be applied to type `for<'r> fn(&'r i32) -> &'r i32 {foo}`
  --> $DIR/issue-77910-1.rs:8:5
   |
LL |     assert_eq!(foo, y);
   |     |
   |     |
   |     for<'r> fn(&'r i32) -> &'r i32 {foo}
   |
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)


error[E0277]: `for<'r> fn(&'r i32) -> &'r i32 {foo}` doesn't implement `Debug`
  --> $DIR/issue-77910-1.rs:8:5
   |
LL |     assert_eq!(foo, y);
   |     ^^^^^^^^^^^^^^^^^^^ `for<'r> fn(&'r i32) -> &'r i32 {foo}` cannot be formatted using `{:?}` because it doesn't implement `Debug`
   |
   = help: the trait `Debug` is not implemented for `for<'r> fn(&'r i32) -> &'r i32 {foo}`
   = note: required because of the requirements on the impl of `Debug` for `&for<'r> fn(&'r i32) -> &'r i32 {foo}`
   = note: required by `std::fmt::Debug::fmt`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 2 previous errors

Some errors have detailed explanations: E0277, E0369.
For more information about an error, try `rustc --explain E0277`.
For more information about an error, try `rustc --explain E0277`.



The actual stderr differed from the expected stderr.
Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/issue-77910-1/issue-77910-1.stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args binop/issue-77910-1.rs`
error: 1 errors occurred comparing output.
status: exit code: 1
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/binop/issue-77910-1.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/issue-77910-1" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/binop/issue-77910-1/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error[E0369]: binary operation `==` cannot be applied to type `for<'r> fn(&'r i32) -> &'r i32 {foo}`
  --> /checkout/src/test/ui/binop/issue-77910-1.rs:8:5
   |
LL |     assert_eq!(foo, y);
   |     |
   |     |
   |     for<'r> fn(&'r i32) -> &'r i32 {foo}
   |
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)


error[E0277]: `for<'r> fn(&'r i32) -> &'r i32 {foo}` doesn't implement `Debug`
  --> /checkout/src/test/ui/binop/issue-77910-1.rs:8:5
   |
LL |     assert_eq!(foo, y);
   |     ^^^^^^^^^^^^^^^^^^^ `for<'r> fn(&'r i32) -> &'r i32 {foo}` cannot be formatted using `{:?}` because it doesn't implement `Debug`
   |
   = help: the trait `Debug` is not implemented for `for<'r> fn(&'r i32) -> &'r i32 {foo}`
   = note: required because of the requirements on the impl of `Debug` for `&for<'r> fn(&'r i32) -> &'r i32 {foo}`
   = note: required by `std::fmt::Debug::fmt`
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)
error: aborting due to 2 previous errors

Some errors have detailed explanations: E0277, E0369.
For more information about an error, try `rustc --explain E0277`.
---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:17:27

lcnr · 2020-12-20T16:50:41Z

@bors r+ rollup

bors · 2020-12-20T16:50:43Z

📌 Commit 00bb293 has been approved by lcnr

Fix ICE when lookup method in trait for type that have bound vars Closes rust-lang#77910

Rollup of 11 pull requests Successful merges: - rust-lang#80159 (Add array search aliases) - rust-lang#80166 (Edit rustc_middle docs) - rust-lang#80170 (Fix ICE when lookup method in trait for type that have bound vars) - rust-lang#80171 (Edit rustc_middle::ty::TyKind docs) - rust-lang#80199 (also const-check FakeRead) - rust-lang#80211 (Handle desugaring in impl trait bound suggestion) - rust-lang#80236 (Use pointer type in AtomicPtr::swap implementation) - rust-lang#80239 (Update Clippy) - rust-lang#80240 (make sure installer only creates directories in DESTDIR) - rust-lang#80244 (Cleanup markdown span handling) - rust-lang#80250 (Minor cleanups in LateResolver) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned oli-obk Dec 18, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2020

lcnr reviewed Dec 19, 2020

View reviewed changes

compiler/rustc_typeck/src/check/method/mod.rs Outdated Show resolved Hide resolved

ldm0 force-pushed the fixice branch from fb8e016 to 5174f1f Compare December 20, 2020 08:21

ldm0 marked this pull request as draft December 20, 2020 08:35

ldm0 force-pushed the fixice branch from 5174f1f to 5a9fe75 Compare December 20, 2020 08:37

lcnr reviewed Dec 20, 2020

View reviewed changes

compiler/rustc_typeck/src/check/op.rs Outdated Show resolved Hide resolved

ldm0 force-pushed the fixice branch from 5a9fe75 to 0d42e42 Compare December 20, 2020 11:52

Fix ICE on suggesting calling function

a33f6ac

ldm0 force-pushed the fixice branch from 0d42e42 to a33f6ac Compare December 20, 2020 11:53

ldm0 marked this pull request as ready for review December 20, 2020 12:48

lcnr reviewed Dec 20, 2020

View reviewed changes

compiler/rustc_typeck/src/check/op.rs Outdated Show resolved Hide resolved

rust-highfive assigned lcnr and unassigned oli-obk Dec 20, 2020

Update compiler/rustc_typeck/src/check/op.rs

4eb28c3

Co-authored-by: lcnr <[email protected]>

lcnr reviewed Dec 20, 2020

View reviewed changes

src/test/compile-fail/issue-77910-1.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2020

Move test from compile-fail to ui/binop

00bb293

ldm0 force-pushed the fixice branch from ccdf582 to 00bb293 Compare December 20, 2020 16:28

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 21, 2020

Rollup merge of rust-lang#80170 - ldm0:fixice, r=lcnr

dc977bd

Fix ICE when lookup method in trait for type that have bound vars Closes rust-lang#77910

This was referenced Dec 21, 2020

Rollup of 11 pull requests #80252

Closed

Rollup of 11 pull requests #80253

Merged

bors merged commit d729e76 into rust-lang:master Dec 21, 2020

rustbot added this to the 1.50.0 milestone Dec 21, 2020

ldm0 deleted the fixice branch December 21, 2020 08:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix ICE when lookup method in trait for type that have bound vars #80170

Fix ICE when lookup method in trait for type that have bound vars #80170

Uh oh!

ldm0 commented Dec 18, 2020

Uh oh!

rust-highfive commented Dec 18, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnr commented Dec 20, 2020

Uh oh!

Uh oh!

lcnr commented Dec 20, 2020

Uh oh!

bors commented Dec 20, 2020

Uh oh!

rust-log-analyzer commented Dec 20, 2020

Uh oh!

lcnr commented Dec 20, 2020

Uh oh!

bors commented Dec 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Fix ICE when lookup method in trait for type that have bound vars #80170

Fix ICE when lookup method in trait for type that have bound vars #80170

Uh oh!

Conversation

ldm0 commented Dec 18, 2020

Uh oh!

rust-highfive commented Dec 18, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lcnr commented Dec 20, 2020

Uh oh!

Uh oh!

lcnr commented Dec 20, 2020

Uh oh!

bors commented Dec 20, 2020

Uh oh!

rust-log-analyzer commented Dec 20, 2020

Uh oh!

lcnr commented Dec 20, 2020

Uh oh!

bors commented Dec 20, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants