Generalize and inline slice::fill specializations #83245
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Odd, this didn't show up when running tidy locally. |
This should also improve cross-crate inlining since the method is generic
the8472
force-pushed
the
generalize-slice-fill
branch
from
9a25668 to
d7fdd90
Compare
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rustbot
added
the
S-waiting-on-perf
|
⌛ Trying commit d7fdd90 with merge ce671292e8a00a0c94483a1fe89485bb08d4762b... |
|
☀️ Try build successful - checks-actions |
|
Queued ce671292e8a00a0c94483a1fe89485bb08d4762b with parent 36f1f04, future comparison URL. |
|
Finished benchmarking try commit (ce671292e8a00a0c94483a1fe89485bb08d4762b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
rustbot
removed
the
S-waiting-on-perf
|
@rustbot label T-libs-impl |
rustbot
added
the
T-libs
|
Thanks! @bors r+ |
|
📌 Commit d7fdd90 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
…Jung,joboet specialize slice::fill to use memset when possible It helps const eval performance rust-lang/miri#4616, debug builds and the gcc backend. Previously attempted in rust-lang#83245 but reverted due to unsoundness rust-lang#87891 around potentially-uninitialized types. This PR only handles primitives where the problem does not arise. split off from rust-lang#147294
…Jung,joboet specialize slice::fill to use memset when possible It helps const eval performance rust-lang/miri#4616, debug builds and the gcc backend. Previously attempted in rust-lang#83245 but reverted due to unsoundness rust-lang#87891 around potentially-uninitialized types. This PR only handles primitives where the problem does not arise. split off from rust-lang#147294
Rollup merge of #147457 - the8472:slice_fill_memset2, r=RalfJung,joboet specialize slice::fill to use memset when possible It helps const eval performance rust-lang/miri#4616, debug builds and the gcc backend. Previously attempted in #83245 but reverted due to unsoundness #87891 around potentially-uninitialized types. This PR only handles primitives where the problem does not arise. split off from #147294
…Jung,joboet specialize slice::fill to use memset when possible It helps const eval performance rust-lang/miri#4616, debug builds and the gcc backend. Previously attempted in rust-lang#83245 but reverted due to unsoundness rust-lang#87891 around potentially-uninitialized types. This PR only handles primitives where the problem does not arise. split off from rust-lang#147294
9 participants
This makes the memset specialization applicable to more types. And since the code now lives in a generic method it is also eligible for cross-crate inlining which should fix #83235