Fix a few details in THIR unsafeck #85627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
LeSeulArtichaut
force-pushed
the
thir-unsafe-fn-lint
branch
from
ddbc3b1 to
d2c2ba8
Compare
nikomatsakis
approved these changes
May 24, 2021
|
@bors r+ |
|
📌 Commit d2c2ba8 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 25, 2021
…, r=nikomatsakis Fix a few details in THIR unsafeck This makes it consistent with RFC 2585 (`unsafe_op_in_unsafe_fn`) and with the MIR unsafeck. r? `@nikomatsakis`
bors
added
S-waiting-on-author
|
Ah, that's #85628, I need to change NULL to null. Sorry, I should have fixed that earlier |
LeSeulArtichaut
force-pushed
the
thir-unsafe-fn-lint
branch
from
d2c2ba8 to
f9e08cd
Compare
|
Should be good to go again |
|
@bors r+ |
|
📌 Commit f9e08cd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#85478 (Disallow shadowing const parameters) - rust-lang#85625 (Prevent double drop in `Vec::dedup_by` if a destructor panics) - rust-lang#85627 (Fix a few details in THIR unsafeck) - rust-lang#85633 (Post-monomorphization errors traces MVP) - rust-lang#85670 (Remove arrays/IntoIterator message from Iterator trait.) - rust-lang#85678 (fix `matches!` and `assert_matches!` on edition 2021) - rust-lang#85679 (Remove num_as_ne_bytes feature) - rust-lang#85712 (Fix typo in core::array::IntoIter comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with RFC 2585 (
unsafe_op_in_unsafe_fn) and with the MIR unsafeck.r? @nikomatsakis