Skip to content

Remove special case for ExprKind::Paren in MutVisitor #87284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2021
Merged

Remove special case for ExprKind::Paren in MutVisitor #87284

merged 1 commit into from
Jul 20, 2021

Conversation

@Aaron1011
Copy link
Contributor

@Aaron1011 Aaron1011 commented Jul 19, 2021

The special case breaks several useful invariants (ExpnIds are
globally unique, and never change). This special case
was added back in 2016 in #34355

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2021
@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Jul 19, 2021

Fixes #87274

@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Jul 19, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 19, 2021

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 19, 2021
@bors
Copy link
Collaborator

bors commented Jul 19, 2021

⌛ Trying commit 208bc2d83fbcd478aacbd62b4f6f9f18f3d4379e with merge 2f692747360443b2e47774330701e5705186fcec...

@bors
Copy link
Collaborator

bors commented Jul 19, 2021

☀️ Try build successful - checks-actions
Build commit: 2f692747360443b2e47774330701e5705186fcec (2f692747360443b2e47774330701e5705186fcec)

@rust-timer
Copy link
Collaborator

rust-timer commented Jul 19, 2021

Queued 2f692747360443b2e47774330701e5705186fcec with parent 8df945c, future comparison URL.

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2021
@rust-timer
Copy link
Collaborator

rust-timer commented Jul 19, 2021

Finished benchmarking try commit (2f692747360443b2e47774330701e5705186fcec): comparison url.

Summary: This benchmark run did not return any significant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 19, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 19, 2021

@bors r+ rollup=maybe

@bors
Copy link
Collaborator

bors commented Jul 19, 2021

📌 Commit 208bc2d83fbcd478aacbd62b4f6f9f18f3d4379e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2021
@petrochenkov
Copy link
Contributor

petrochenkov commented Jul 19, 2021

Oh, wait, could you fix the typo ExpnKind -> ExprKind in the commit and PR titles?
r=me after that.
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 19, 2021
@Aaron1011
Remove special case for ExprKind::Paren in MutVisitor
f9f238e 
The special case breaks several useful invariants (`ExpnId`s are
globally unique, and never change). This special case
was added back in 2016 in rust-lang#34355
@Aaron1011 Aaron1011 force-pushed the remove-paren-special branch from 208bc2d to f9f238e Compare July 19, 2021 22:23
@Aaron1011 Aaron1011 changed the title Remove special case for ExpnKind::Paren in MutVisitor Remove special case for ExprKind::Paren in MutVisitor Jul 19, 2021
@Aaron1011
Copy link
Contributor Author

Aaron1011 commented Jul 19, 2021

@bors r=petrochenkov p=1

This unbreaks a perf benchmark

@bors
Copy link
Collaborator

bors commented Jul 19, 2021

📌 Commit f9f238e has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 19, 2021
@bors
Copy link
Collaborator

bors commented Jul 19, 2021

⌛ Testing commit f9f238e with merge 6535449...

@bors
Copy link
Collaborator

bors commented Jul 20, 2021

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 6535449 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 20, 2021
@bors bors merged commit 6535449 into rust-lang:master Jul 20, 2021
@rustbot rustbot added this to the 1.55.0 milestone Jul 20, 2021
This was referenced Jul 20, 2021
Closed
Closed
@mockersf mockersf mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.55.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Aaron1011 @rust-timer @bors @petrochenkov @rust-highfive @rustbot