Add #[must_use] to mem/ptr functions #89839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jkugelman
force-pushed
the
must-use-mem-ptr-functions
branch
from
f2ee250 to
10d3f51
Compare
apiraino
added
the
T-libs
|
One minor nit; r=me with that fixed. |
joshtriplett
added
the
relnotes
jkugelman
force-pushed
the
must-use-mem-ptr-functions
branch
from
10d3f51 to
887503a
Compare
|
@bors r+ |
|
📌 Commit 887503a has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…s, r=joshtriplett Add #[must_use] to mem/ptr functions There's a lot of low-level / unsafe stuff here. Are there legit use cases for ignoring any of these return values? * No regressions in `./x.py test --stage 1 library/std src/tools/clippy`. * One regression in `./x.py test --stage 1 src/test/ui`. Fixed. * I am unable to run `./x.py doc` on my machine so I'll need to wait for the CI to verify doctests pass. I eyeballed all the adjacent tests and they all look okay. Parent issue: rust-lang#89692 r? `@joshtriplett`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…s, r=joshtriplett Add #[must_use] to mem/ptr functions There's a lot of low-level / unsafe stuff here. Are there legit use cases for ignoring any of these return values? * No regressions in `./x.py test --stage 1 library/std src/tools/clippy`. * One regression in `./x.py test --stage 1 src/test/ui`. Fixed. * I am unable to run `./x.py doc` on my machine so I'll need to wait for the CI to verify doctests pass. I eyeballed all the adjacent tests and they all look okay. Parent issue: rust-lang#89692 r? ``@joshtriplett``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 31, 2021
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#89446 (Add paragraph to ControlFlow docs to menion it works with the ? operator (rust-lang#88715)) - rust-lang#89677 (Stabilize `is_symlink()` for `Metadata` and `Path`) - rust-lang#89833 (Add #[must_use] to Rc::downgrade) - rust-lang#89835 (Add #[must_use] to expensive computations) - rust-lang#89839 (Add #[must_use] to mem/ptr functions) - rust-lang#89897 (Add #[must_use] to remaining core functions) - rust-lang#89951 (Stabilize `option_result_unwrap_unchecked`) - rust-lang#90427 (Add #[must_use] to alloc functions that would leak memory) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a lot of low-level / unsafe stuff here. Are there legit use cases for ignoring any of these return values?
./x.py test --stage 1 library/std src/tools/clippy../x.py test --stage 1 src/test/ui. Fixed../x.py docon my machine so I'll need to wait for the CI to verify doctests pass. I eyeballed all the adjacent tests and they all look okay.Parent issue: #89692
r? @joshtriplett