Skip to content

Conversation

lilasta
Copy link
Contributor

@lilasta lilasta commented Jan 23, 2022

Tracking issue: #93235

@lilasta
Copy link
Contributor Author

lilasta commented Jan 24, 2022

@rustbot label +S-waiting-on-review +T-libs

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 24, 2022
@lilasta
Copy link
Contributor Author

lilasta commented Jan 24, 2022

r? @oli-obk

(is rust-highfive stopped...?)

@oli-obk
Copy link
Contributor

oli-obk commented Jan 25, 2022

lgtm, please add tests of this function being used in a const item (one for Some and one for None).

@lilasta
Copy link
Contributor Author

lilasta commented Jan 28, 2022

Added.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 28, 2022

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 28, 2022

📌 Commit cdd0873 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#88205 (Add Explanation For Error E0772)
 - rust-lang#92274 (Add `intrinsics::const_deallocate`)
 - rust-lang#93236 (Make `NonNull::new` `const`)
 - rust-lang#93299 (Fix dot separator when there is no source link)
 - rust-lang#93410 (kmc-solid: Implement `net::FileDesc::duplicate`)
 - rust-lang#93424 (fix nit)
 - rust-lang#93431 (remove unused `jemallocator` crate)
 - rust-lang#93453 (Add GUI theme change test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 37e9cb3 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
@lilasta lilasta deleted the const_nonnull_new branch January 30, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants