Migrate more diagnostics to use the #[derive(SessionDiagnostic)]
#97587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
pvdrz
changed the title
maybe_recover_from_bad_qpath_stage_2 diagnostic#[derive(SessionDiagnostic)]
davidtwco
approved these changes
Jun 1, 2022
|
@bors delegate+ |
|
✌️ @pvdrz can now approve this pull request |
|
@bors r+ |
|
@bors r=davidtwco |
|
📌 Commit 0fa70a8 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jun 2, 2022
…stage-2, r=davidtwco Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]` r? `@davidtwco`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 2, 2022
Rollup of 6 pull requests Successful merges: - rust-lang#96894 (Apply track_caller to closure on `expect_non_local()`) - rust-lang#97023 (Diagnose anonymous lifetimes errors more uniformly between async and regular fns) - rust-lang#97397 (Stabilize `box_into_pin`) - rust-lang#97587 (Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]`) - rust-lang#97603 (Arc make_mut doc comment spelling correction.) - rust-lang#97635 (Fix file metadata documentation for Windows) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
compiler-errors
added
the
A-translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @davidtwco