Mark arm_shared intrinsics as stable on all target except ARM #1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Amanieu: no appropriate reviewer found, use r? to override |
Currently these are only marked as stable on aarch64, which makes them appear as unstable in the standard library docs generated on x86_64. This is still somewhat misleading in the case of ARM since it makes the docs show some functions as stable when they aren't, but this is still better than the status quo.
Amanieu
force-pushed
the
fix-aarch64-docs
branch
from
43ef4a5 to
b6dff39
Compare
Amanieu
added a commit
to Amanieu/stdarch
that referenced
this pull request
Mar 23, 2023
This is a follow-up to rust-lang#1345 where these appeared as unstable in the standard library docs because they are only stabilized for ARM. They were missed in the original PR.
Amanieu
added a commit
that referenced
this pull request
Mar 24, 2023
This is a follow-up to #1345 where these appeared as unstable in the standard library docs because they are only stabilized for ARM. They were missed in the original PR.
Amanieu
added a commit
to Amanieu/stdarch
that referenced
this pull request
Jun 28, 2023
This happens because the docs are built for x86_64, see rust-lang#1345. Fixes rust-lang#1444
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these are only marked as stable on aarch64, which makes them appear as unstable in the standard library docs generated on x86_64.
This is still somewhat misleading in the case of ARM since it makes the docs show some functions as stable when they aren't, but this is still better than the status quo.