grant ability to merge rustfmt PRs #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rustfmt repo doesn't have bors enabled, the rustfmt team only consists of 2 people, myself and Yacin (who's on vacation for the next couple weeks), and we've got a branch protection policy that requires a review.
I've got some sequential work for the rustfmt 2024 items that's predicated on getting some things merged, which means I'm completely blocked at the moment. I previously had the ability to override this as an admin, but based on some discussion in Zulip my understanding is that the repo permissions were changed and the way to "override" this now is to temporarily disable the review requirement.