Skip to content

Give libs and libs-contributors write access to wg-allocators #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Give libs and libs-contributors write access to wg-allocators #1881

merged 1 commit into from
Jun 22, 2025

Conversation

@tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jun 19, 2025

The allocator API overlaps with libs quite a bit, so allow these teams access for issue triage.

r? @Amanieu

@github-actions
Copy link

github-actions bot commented Jun 19, 2025 •
edited
Loading

Dry-run check results 

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/wg-allocators':
      Permission Changes:
        Giving team 'libs' write permission
        Giving team 'libs-contributors' write permission
        Giving team 'libs-api' write permission

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 22, 2025

Maybe libs-api too?

@Mark-Simulacrum Mark-Simulacrum added this pull request to the merge queue Jun 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 22, 2025
@tgross35
Give libs, libs-api, and libs-contributors write access to wg-allocators
c603db1 
The allocator API overlaps with libs quite a bit, so allow these teams
access for issue triage.
@tgross35
Copy link
Contributor Author

tgross35 commented Jun 22, 2025

Yeah that makes sense, updated

auto-merge was automatically disabled June 22, 2025 22:44

Pull request was closed

@Mark-Simulacrum Mark-Simulacrum added this pull request to the merge queue Jun 22, 2025
@steffahn
Copy link
Member

steffahn commented Jun 22, 2025

I'm wondering: would adding a CI trigger for auto_merge_enabled type of the pull_request event, besides the implicit default list of [opened, synchronize and reopened], avoid the need for such re-opening?

@steffahn steffahn mentioned this pull request Jun 22, 2025
Open
Merged via the queue into rust-lang:master with commit 8f8fee4 Jun 22, 2025
6 of 12 checks passed
@tgross35 tgross35 deleted the allocators-libs branch June 23, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

+1 more reviewer

@Amanieu Amanieu Amanieu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tgross35 @Mark-Simulacrum @steffahn @Amanieu