Skip to content

Fix PR comment deserialization #1649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Fix PR comment deserialization #1649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,10 @@ pub struct Issue {
/// Note that this field does not come from GitHub. This is manually added
/// when the webhook arrives to help differentiate between an event
/// related to an issue versus a pull request.
#[serde(default)]
///
/// GitHub *does* actually populate this field on some events, but triagebot ignores that data
/// and just stores a bool here when appropriate.
#[serde(skip)]
pub pull_request: bool,
/// Whether or not the pull request was merged.
#[serde(default)]
Expand Down