Improve removal of multiple GitHub labels at the same time #2190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
commented
Oct 2, 2025
| pub async fn remove_labels( | ||
| &self, | ||
| client: &GithubClient, | ||
| labels: Vec<Label>, |
Member
Author
There was a problem hiding this comment.
It's unclear to me if taking a Vec<Label> is the right choice, in most cases we need to convert Vec<&str>/Vec<String> to it. Maybe we should take an impl IntoIterator<Item = &str> or something like that.
Member
There was a problem hiding this comment.
I think it's fine, although I'd use &[Label], but that doesn't matter that much (it would probably require more generic annotations).
Kobzol
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub doesn't offer an API to remove multiple labels at the same time, this leads us to have to manually have for-loops to remove multiple of them.
Instead I propose that we paper over GitHub's API and do the multiple API calls (in parallel) in our helper, that will make the function consistent with
add_labelsand allow us to process the removal in parallel.