windows: move BCryptGenRandom to helper function #318
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This _is not_ a functional change. It just makes adding additional fallback implementations easier in the future. Note that the try_into().unwrap() is optimized away: https://godbolt.org/z/nbThsqsTE Signed-off-by: Joe Richey <[email protected]>
|
I think it will be better to have one PR with fallback implementation, instead of splitting it into several. |
Sounds reasonable, I'll move this to draft then. |
|
Closing, we went with a different approach in #337 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a functional change. It just makes adding additional fallback implementations easier in the future.
Note that the try_into().unwrap() is optimized away: https://godbolt.org/z/nbThsqsTE
I was originally going to try to use
BCRYPT_RNG_ALG_HANDLEand fall back to our currently implementation, but that will cause segfaults on older versions.Signed-off-by: Joe Richey [email protected]