Unconditionally use libc::getrandom on FreeBSD #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust's minimum version is now FreeBSD 12, so we can drop the fallback code. We have to keep the NetBSD fallback code as NetBSD 10 is still quite new. Signed-off-by: Joe Richey <[email protected]>
newpavlov
approved these changes
May 2, 2024
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Maybe rename bsd_arandom.rs to netbsd.rs?
Signed-off-by: Joe Richey <[email protected]>
Member
Author
Done |
Merged
Contributor
The current MSRV does support FreeBSD 11, so this seems premature if the reason is what Rust supports. A better reason is that FreeBSD 11 is EOL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412
Rust's minimum version is now FreeBSD 12, so we can drop the fallback code. We have to keep the NetBSD fallback code as NetBSD 10 is still quite new.