DO_NOT_MERGE: a draft design for interrupt management #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
P.S. you can create a draft PR. The draft PR cannot be merged. Check it out here: https://github.blog/2019-02-14-introducing-draft-pull-requests/ |
liujing2
reviewed
Aug 5, 2019
sboeuf
reviewed
Aug 7, 2019
sboeuf
reviewed
Aug 7, 2019
sameo
reviewed
Aug 12, 2019
| //! | ||
| //! The overall flow to deal with interrupts is: | ||
| //! * the VMM creates an interrupt manager | ||
| //! * the VMM creates a device manager, passing on an reference to the interrupt manager |
There was a problem hiding this comment.
For the sake of API simplicity, should we have the device manager creation API implicitly create the interrupt manager?
Do you need access to the interrupt manager from the VMM itself?
sameo
reviewed
Aug 12, 2019
Member
Author
|
Sure, I will address comments and then create a formal PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft for interrupt management, which aims to decouple the vm-allocator crate from the vm-device crate.
@sboeuf @liujing2 @sameo @andreeaflorescu Please help to take a look at the proposal:)