refactor(writer): avoid some intermediate allocations #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogti
force-pushed
the
no-intermed-cstr
branch
from
4dbb673 to
37a1892
Compare
fogti
commented
Nov 1, 2025
fogti
force-pushed
the
no-intermed-cstr
branch
from
37a1892 to
ac277d9
Compare
This doesn't change the public interface at all, but should also make it easier to avoid intermediate allocations in the future. Signed-off-by: Ellen Εμιλία Άννα Zscheile <[email protected]>
fogti
force-pushed
the
no-intermed-cstr
branch
from
ac277d9 to
f83bfa2
Compare
danielverkamp
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
This PR reduces the amount of intermediate allocations done in
property_stringandproperty_string_list.This doesn't change the public interface at all, but should also make it easier to avoid intermediate allocations in the future. (see also PR #76 as something it might be utilized in conjunction with).
Background:
vm-fdtis used by https://github.com/hermit-os/loader/blob/0c1c1a819fa77016672a620ebaa44e79b8c95599/src/fdt.rs, which is an environment where we want to avoid allocations, particularly of small, intermediate buffers as much as possible, particularly when such buffers aren't a necessity and can be avoided relatively easily.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.