Skip to content

Conversation

domenkozar
Copy link
Contributor

No description provided.

@jalil-salame
Copy link
Contributor

Please sign off your commit and add a simple message to the body (e.g. tonic 0.13 was released $DATE with a link to the release notes).

@domenkozar
Copy link
Contributor Author

@jalil-salame I've updated the commit message, but I can't sign it since I no longer use GPG.

@domenkozar domenkozar requested a review from jalil-salame April 10, 2025 09:05
@jalil-salame
Copy link
Contributor

@jalil-salame I've updated the commit message, but I can't sign it since I no longer use GPG.

Signing and sign off are different things, sign off is to add a trailer Signed-off-by: name <email>) git does this if you pass the --sign-off flag.

Sorry for the confusion

tonic 0.13 was released on 2025/03/25: https://github.com/hyperium/tonic/releases/tag/v0.13.0

Signed-off-by: Domen Kožar <[email protected]>
@domenkozar
Copy link
Contributor Author

Alright, done! I'd appreciate a release so that we can also land tokio-rs/console#623

@jalil-salame
Copy link
Contributor

Alright, done! I'd appreciate a release so that we can also land tokio-rs/console#623

I don't have permission to make release so @qwandor friendly ping?

@qwandor qwandor merged commit 54b853f into rust-vsock:master Apr 10, 2025
3 checks passed
@qwandor
Copy link
Contributor

qwandor commented Apr 10, 2025

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants