Skip to content

Conversation

@madsmtm
Copy link
Member

@madsmtm madsmtm commented Apr 23, 2024

Fixes #181.

This also prevents accessing the NSView/NSWindow from other threads than the main thread.

@madsmtm madsmtm added the CoreGraphics macOS/iOS/tvOS/watchOS/visionOS backend label Apr 23, 2024
@madsmtm madsmtm requested a review from john01dav as a code owner April 23, 2024 14:52
@madsmtm madsmtm changed the title Use objc2 Use objc2 Apr 23, 2024
SoftBufferError is `#[non_exhaustive]`, so it's fine to add further
variants to it. I decided against doing that though, as the error is
platform-specific, and not one that the program can really handle in any
reasonable way (it's closer to a programmer error).
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@notgull notgull merged commit 28ebe6e into master Apr 29, 2024
@notgull notgull deleted the madsmtm/objc2 branch April 29, 2024 23:48
@notgull notgull mentioned this pull request May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CoreGraphics macOS/iOS/tvOS/watchOS/visionOS backend

Development

Successfully merging this pull request may close these issues.

Migrate from objc to objc2

4 participants