Skip to content

Conversation

@ianmclinden
Copy link
Contributor

No description provided.

@jgarzik
Copy link
Contributor

jgarzik commented Aug 8, 2024

@ianmclinden Please update this to the latest main branch, to solve CI build failure.

@jgarzik
Copy link
Contributor

jgarzik commented Aug 8, 2024

It looks good as a first pass, and passes CI.

However, it is missing the -E and -e arguments specified by POSIX.

@ianmclinden
Copy link
Contributor Author

Can implement. Do you have reference for -E ? Neither Open Group Base nor any of my mans have that flag

@jgarzik
Copy link
Contributor

jgarzik commented Aug 8, 2024

Can implement. Do you have reference for -E ? Neither Open Group Base nor any of my mans have that flag

I am happy to share the specification privately, but cannot share publicly.

@ianmclinden
Copy link
Contributor Author

ianmclinden commented Aug 9, 2024

Implemented -e|--canonicalize_existing, and -E along with the common -q|--quiet.

Errors are left raw from clap for invalid paths - i.e. '' arguments return the raw clap error error: one of the values isn't valid for an argument

@jgarzik jgarzik merged commit f48fa26 into rustcoreutils:main Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants