Skip to content

Conversation

@andrewliebenow
Copy link
Contributor

No description provided.

Copy link
Contributor

@jgarzik jgarzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks OK. Minor nit commented.

@jgarzik jgarzik merged commit 3ddf78b into rustcoreutils:main Sep 15, 2024
2 checks passed
@jgarzik
Copy link
Contributor

jgarzik commented Sep 15, 2024

Unfortunately, post-merge, a megaton of new build warnings appeared on macos (and probably linux also), so had to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants