paste: allow empty -d, and stdin #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow an empty delimiter list, so the program can do something useful in this case, instead of just exiting. Also, some other implementations of `paste` permit this use case, and users of paste rely on this functionality. [1] Also, read from stdin if "-" is passed. [1] https://stackoverflow.com/questions/1251999/how-can-i-replace-each-newline-n-with-a-space-using-sed/7697604#7697604
|
As with the musl comment: changes such as grep spelling should be in a separate commit from the paste changes, since the two are entirely unrelated. |
I'll try to make sure to do that in the future. Should small fixes like that go in separate PRs, too, or are separate commits sufficient? |
Separate commits at a minimum. If the change is large and logically separate, a separate PR is ideal. If it's just small incidental cleanups, the same PR is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an empty delimiter list, so the program can do something useful in this case, instead of just exiting. Also, some other implementations of
pastepermit this use case, and users of paste rely on this functionality. [1] Also, read from stdin if "-" is passed.[1] https://stackoverflow.com/questions/1251999/how-can-i-replace-each-newline-n-with-a-space-using-sed/7697604#7697604