Skip to content

Conversation

@Wandalen
Copy link
Contributor

@Wandalen Wandalen commented Oct 4, 2024

No description provided.

@Wandalen Wandalen marked this pull request as draft October 4, 2024 16:50
@Wandalen Wandalen marked this pull request as ready for review October 4, 2024 16:55
Copy link
Contributor

@jgarzik jgarzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot rely on outside binaries such as nroff or groff. :(

@jgarzik jgarzik added the enhancement New feature or request label Oct 17, 2024
@Wandalen Wandalen marked this pull request as draft October 26, 2024 06:46
@Wandalen Wandalen marked this pull request as ready for review April 18, 2025 06:21
@Wandalen
Copy link
Contributor Author

@jgarzik 22k of LoC ready for your review, sir 🫡

@jgarzik
Copy link
Contributor

jgarzik commented May 9, 2025

@Wandalen Overall looks very good! What an ambitious contribution!

Simple but large PR update, then I will merge: move this from ./display to its own ./man top-level directory and crate within the posixutils workspace. (remember, do not use src directory)

@Wandalen Wandalen marked this pull request as draft May 10, 2025 09:52
@Wandalen Wandalen marked this pull request as ready for review May 10, 2025 11:22
@Wandalen
Copy link
Contributor Author

@jgarzik Sir, it's done.
Any other improvements you would glad to see?

@jgarzik jgarzik merged commit 72788d8 into rustcoreutils:main Jul 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants