Skip to content

feat: allow use documents other than window.document during render #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: allow use documents other than window.document during render #253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/dom-expressions/src/client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,19 @@ export {
voidFn as HydrationScript
};

const documents = new WeakMap()

export function render(code, element, init, options = {}) {
let disposer;
const owner = { ...options.owner }
owner.root = owner
documents.set(owner, element.ownerDocument ?? document)
root(dispose => {
disposer = dispose;
element === document
? code()
: insert(element, code(), element.firstChild ? null : undefined, init);
}, options.owner);
}, owner);
return () => {
disposer();
element.textContent = "";
Expand All @@ -67,7 +72,7 @@ export function template(html, isCE, isSVG) {
};
// backwards compatible with older builds
const fn = isCE
? () => untrack(() => document.importNode(node || (node = create()), true))
? () => untrack(() => documents.get(getOwner().root).importNode(node || (node = create()), true))
: () => (node || (node = create())).cloneNode(true);
fn.cloneNode = fn;
return fn;
Expand Down