Skip to content

Add a "Source Information" section to the "Session Info" tab when vie… #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rockinrimmer
Copy link
Contributor

@rockinrimmer rockinrimmer commented Jul 26, 2025

…wing a session. This displays Channel, Referrer and Entry Page.

Summary by CodeRabbit

  • New Features

    • Added a "Source Information" section to session details, displaying Channel, Referrer, and Entry Page fields.
    • The session details layout now adapts to a three-column format on large screens for improved readability.
  • Enhancements

    • Channel information is now captured and displayed as part of session metadata.

…wing a session. This displays Channel, Referrer and Entry Page.
Copy link

vercel bot commented Jul 26, 2025

@rockinrimmer is attempting to deploy a commit to the goldflag's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jul 26, 2025

Walkthrough

A new channel property was added to the SessionDetails interface in both client and server code. The server's session aggregation SQL query was updated to include the channel, and the client UI now displays channel information in a new "Source Information" section within the session details view, using a three-column layout.

Changes

File(s) Change Summary
client/src/api/analytics/userSessions.ts
server/src/api/analytics/getSession.ts
Added channel: string to the SessionDetails interface in both client and server code.
server/src/api/analytics/getSession.ts Updated SQL query to aggregate and return the channel field with session details.
client/src/components/Sessions/SessionDetails.tsx Changed grid layout to three columns; added "Source Information" section displaying channel, etc.

Sequence Diagram(s)

sequenceDiagram
    participant Browser
    participant ClientAPI
    participant ServerAPI
    participant Database

    Browser->>ClientAPI: Request session details
    ClientAPI->>ServerAPI: Fetch session details
    ServerAPI->>Database: Query session data (including channel)
    Database-->>ServerAPI: Return session data with channel
    ServerAPI-->>ClientAPI: Return session details (with channel)
    ClientAPI-->>Browser: Render session details (show channel in UI)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

In columns of three, the sessions now show
A channel revealed where secrets may flow.
With referrer and entry, the source is in sight,
The data hops swiftly from backend to light.
A bunny approves, with a hop and a cheer—
More clarity for sessions, the purpose is clear!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 895ca2d and 1199738.

📒 Files selected for processing (3)
  • client/src/api/analytics/userSessions.ts (1 hunks)
  • client/src/components/Sessions/SessionDetails.tsx (2 hunks)
  • server/src/api/analytics/getSession.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
{client,server}/**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (CLAUDE.md)

{client,server}/**/*.{ts,tsx}: Use TypeScript with strict typing throughout both client and server
Use try/catch blocks with specific error types for error handling
Use camelCase for variables and functions, PascalCase for components and types
Group imports by external, then internal, and sort alphabetically within groups

Files:

  • client/src/api/analytics/userSessions.ts
  • server/src/api/analytics/getSession.ts
  • client/src/components/Sessions/SessionDetails.tsx
🔇 Additional comments (5)
client/src/api/analytics/userSessions.ts (1)

108-108: LGTM! Interface extension follows TypeScript best practices.

The addition of the channel property to the SessionDetails interface is correctly typed and positioned logically near other source-related fields like referrer.

server/src/api/analytics/getSession.ts (2)

21-21: LGTM! Server interface matches client interface.

The addition of the channel property maintains type consistency between client and server interfaces.


106-106: LGTM! Proper use of ClickHouse aggregate function.

The any(channel) as channel addition correctly retrieves channel data using ClickHouse's aggregate function, which is appropriate for grouped session data.

client/src/components/Sessions/SessionDetails.tsx (2)

366-366: LGTM! Grid layout properly adjusted for three-column layout.

The change from md:grid-cols-2 to lg:grid-cols-[auto_auto_auto] correctly accommodates the new Source Information section while maintaining responsive design.


531-564: LGTM! Well-implemented Source Information section.

The new section follows established patterns with:

  • Consistent styling and structure matching other sections
  • Proper TypeScript optional chaining (sessionDetails?.channel)
  • Appropriate fallback values ("None" for undefined data)
  • Logical grouping of source-related information (Channel, Referrer, Entry Page)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant