Sage's noncommutative rings don't always increment a refcount

[roed314]

Running doctests with the new doctest framework revealed that KeyErrors were being ignored in sage.lib.singular.ring.singular_ring_delete.

CC: @simon-king-jena @malb

Component: commutative algebra

Author: David Roe

Reviewer: Martin Albrecht

Merged: sage-5.4.beta1

Issue created by migration from https://trac.sagemath.org/ticket/13145

[roed314]

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Running doctests with the new doctest framework revealed that KeyErrors were being ignored in `sage.lib.singular.ring.singular_ring_delete`.  The included patch fixes the problem, but I need to add doctests.
+Running doctests with the new doctest framework revealed that `KeyErrors` were being ignored in `sage.lib.singular.ring.singular_ring_delete`.  The included patch fixes the problem, but I need to add doctests.

[roed314]

comment:2

Attachment: 13145.patch.gz

[roed314]

comment:3

My fixes apparently aren't enough: I'm picking up more failures now.

[roed314]

Description changed:

--- 
+++ 
@@ -1 +1 @@
-Running doctests with the new doctest framework revealed that `KeyErrors` were being ignored in `sage.lib.singular.ring.singular_ring_delete`.  The included patch fixes the problem, but I need to add doctests.
+Running doctests with the new doctest framework revealed that `KeyErrors` were being ignored in `sage.lib.singular.ring.singular_ring_delete`.

[roed314]

comment:6

Somehow the problems went away with further changes in the doctest framework. I'm not convinced that no problems remain in this area, but I'm going to return this to "Needs review" for now.