Upgrade bliss package to 0.73 with Debian patches; install header files in location expected by polymake

[mkoeppe]

New upstream archive: http://www.tcs.hut.fi/Software/bliss/bliss-0.73.zip (we have 0.72)

Upstream bliss does not have a proper build system (in particular no 'make install').
"spkg-install" installs header files with generic names such as "graph.hh" flat into $SAGE_LOCAL/include/

Debian has https://packages.debian.org/sid/math/bliss
which autotoolizes the package and adjust the include file location.
This matches where Polymake (#20892) expects the header files.

On https://github.com/mkoeppe/bliss in branch sage_package I have applied the Debian patches and a few more patches for Sage. The spkg-src script clones from there and builds a distribution. The result is available here:

tarball: https://github.com/mkoeppe/bliss/releases/download/sage_package%2F0.73%2Bdebian-1%2Bsage-2016-08-02/bliss-0.73.debian-1.sage-2016-08-02.tar.gz (rename to bliss-0.73+debian-1+sage-2016-08-02.tar.gz)

Upstream: Reported upstream. No feedback yet.

CC: @sagetrac-azi @jdemeyer @videlec @kcrisman @dimpase @fchapoton @stumpc5 @mo271 @vbraun

Component: packages: optional

Author: Matthias Koeppe

Branch: c0c0427

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/20901

[mkoeppe]

Dependencies: #20692

[mkoeppe]

Branch: u/mkoeppe/upgrade_bliss_package_to_0_73_with_debian_patches__install_header_files_in_location_expected_by_polymake

[mkoeppe]

Commit: 3837a48

[mkoeppe]

Description changed:

--- 
+++ 
@@ -7,6 +7,7 @@
 which autotoolizes the package and adjust the include file location.
 This matches where Polymake (#20892) expects the header files.
 
-We should really be using Debian as our upstream for this package.
+Autotoolized package using the Debian patches is available here: 
+https://github.com/mkoeppe/bliss/releases/download/apply_debian_patches%2F0.73-1/bliss-0.73.debian-1.tar.gz
 
 

[mkoeppe]

New commits:

3837a48

bliss: Use autotoolized package from Debian

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Changed dependencies from #20692 to none

[mkoeppe]

comment:5

Needs review. Prerequisite for polymake (#20892).

[dimpase]

comment:6

what are the new goodies? a shared library?

[mkoeppe]

comment:7

Replying to @dimpase:

what are the new goodies? a shared library?

A shared library, proper include files location, and as a result works as a prerequisite for polymake.
New upstream version -- but upstream is silent about what has changed compared to 0.72.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

225755e

bliss: Add more info in SPKG.txt

[sagetrac-git]

Changed commit from 3837a48 to 225755e

[jdemeyer]

comment:9

The usual way to ship packages in Sage is to start from the original unmodified sources and then apply patches (either at packaging time or at build time). Here, you are instead forking upstream for no clear reason.

[sagetrac-git]

Changed commit from 225755e to 4b22211

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4b22211

bliss: Use upstream tarball and patches