Install SAGE_SRC/ext/ in package data of sage package by setup.py, not SAGE_LOCAL/share/sage/ext/ by build/make/Makefile

[mkoeppe]

A lot of the stuff (not necessarily all) in $SAGE_SRC/ext belongs directly in the sage Python package--in particular any files that are needed for the package itself to function properly.

A model for that is sage.gaprc, a file required for the libgap module to work, which is installed in sage.libs.gap as "package data" as of #22626.

In this ticket, we install all of ext as package data of sage.

• In a follow up ticket, if we identify any files in $SAGE_SRC/ext that aren't explicitly required from the package, we will move them to a more appropriate place.

Depends on #29233

CC: @jdemeyer @embray @kiwifb @slel @saraedum @isuruf @dimpase @jhpalmieri

Component: build

Author: Matthias Koeppe

Branch: fef5a5f

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/21785

[kiwifb]

comment:2

That would actually help me. I see extra potential to this for my jupyter kernel install woes as well (even if I know Jeroen doesn't see it that way).

[slel]

comment:3

There was a reference to this ticket in a "sage-packaging" discussion:

• https://groups.google.com/d/msg/sage-packaging/McjYh9wYlmk/PgBK1yryCwAJ

[embray]

comment:4

I would add, a lot of the stuff (not necessarily all) in $SAGE_SRC/ext might better belong directly in the sage Python package--in particular any files that are needed for the package itself to function properly. For example you can see in #22626 that I put sage.gaprc, a file required for the libgap module to work, in sage.libs.gap as "package data".

There are several files in $SAGE_SRC/ext that there's no reason to ever allow to be out of sync with the Python package, and that could be given the same treatment.

For files in $SAGE_SRC/ext in general, that aren't explicitly required from the package (are there any such files) it might be better to move out of src/ entirely?

[embray]

comment:5

Ticket retargeted after milestone closed

[mkoeppe]

comment:7

setuptools experts: To move this ticket forward, should it go through #22655 (Support package_data-like of non-Python resource files in Python packages)?

[embray]

comment:8

Something like it, yes, though I think maybe it can be simplified.

[mkoeppe]

comment:9

Erik, should discussion then take place on #22655 or here?

[mkoeppe]

comment:10

Description adapted from embray's comment 4.

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,9 @@
+A lot of the stuff (not necessarily all) in `$SAGE_SRC/ext` belongs directly in the sage Python package--in particular any files that are needed for the package itself to function properly. 
 
+A model for that is `sage.gaprc`, a file required for the `libgap` module to work, which is installed in `sage.libs.gap` as "package data" as of #22626.
+
+In this ticket, we install all of `ext` as package data of `sage`.
+
+- In a follow up ticket, if we identify any files in `$SAGE_SRC/ext` that aren't explicitly required from the package, we will move them to a more appropriate place.
+
+

[mkoeppe]

Dependencies: #29062

[mkoeppe]

Author: Matthias Koeppe