Upgrade to pynac-0.7.13

[rwst]

There is:

• fix ex.coefficients() bugs (Doctest: segmentation fault with coefficients() on symbolic expressions #23545, Segfault with ex.coefficients #24147)
• fix interface to Singular GCD (Doctest improvements to symbolic GCD #23845)
• fix compiler warnings
• asin/atan enhancements (Some trivial identities and simplifications missed by Sage (pynac ?) #24211)
• set_of_all() function (ConditionSet, ImageSet: Implement formal Set comprehension #24176)
• upgrade ax_cxx_compile_stdcxx_11.m4

https://github.com/pynac/pynac/releases/download/pynac-0.7.13/pynac-0.7.13.tar.bz2

CC: @kiwifb

Component: packages: standard

Author: Ralf Stephan

Branch/Commit: u/rws/upgrade_to_pynac_0_7_13 @ 438816e

Reviewer: Emmanuel Charpentier

Issue created by migration from https://trac.sagemath.org/ticket/24262

[rwst]

Branch: u/rws/upgrade_to_pynac_0_7_13

[kiwifb]

New commits:

46a7ebc

24262: pkg version/chksum

[kiwifb]

Commit: 46a7ebc

[rwst]

comment:3

No doctests need to be adapted for this release. Please review.

[EmmanuelCharpentier]

comment:4

On Debian 8.1.rc2 + #24240, compiles without difficulty.

• fix ex.coefficients() bugs (Doctest: segmentation fault with coefficients() on symbolic expressions #23545, Segfault with ex.coefficients #24147) : yes
• fix interface to Singular GCD (Doctest improvements to symbolic GCD #23845) : yes. The planned doctest don't seem to have been added.
• fix compiler warnings : I still get :

charpent@asus16-ec:~$ cat /usr/local/sage-8/logs/pkgs/pynac-0.7.13.log  | grep warn
/usr/local/sage-8/local/include/flint/fmpz.h:428:23: warning: declaration of 'mpz_ptr' shadows a global declaration [-Wshadow]
/usr/local/sage-8/local/include/flint/fmpz.h:428:23: warning: declaration of 'mpz_ptr' shadows a global declaration [-Wshadow]
/usr/local/sage-8/local/include/flint/fmpz.h:428:23: warning: declaration of 'mpz_ptr' shadows a global declaration [-Wshadow]

• asin/atan enhancements (Some trivial identities and simplifications missed by Sage (pynac ?) #24211) : partial fix :

sage: [arcsin(t) for t in [0, 1/2, sqrt(2)/2, sqrt(3)/2, 1]] # Fixed
[0, 1/6*pi, 1/4*pi, 1/3*pi, 1/2*pi]
sage: [arctan(t) for t in [0, 1/sqrt(3), 1, sqrt(3)]] # Fixed
[0, 1/6*pi, 1/4*pi, 1/3*pi]
sage: [arccos(t) for t in [0, 1/2, sqrt(2)/2, sqrt(3)/2, 1]] # Partially fixed
[1/2*pi, 1/3*pi, arccos(1/2*sqrt(2)), arccos(1/2*sqrt(3)), 0]
sage: [arccot(t) for t in [0, 1/sqrt(3), 1, sqrt(3)]] # Partially fixed
[1/2*pi, arccot(1/3*sqrt(3)), 1/4*pi, arccot(sqrt(3))]

The simplifications are not fixed either (but I'm not sure they could be by pynac's upgrade...) :

sage: assume(-pi/2<x, x<pi/2)
sage: arctan(sin(x)/cos(x)).simplify() # Not fixed
arctan(sin(x)/cos(x))
sage: arctan(sin(x)/cos(x)).simplify_full() # Not fixed
arctan(sin(x)/cos(x))

• set_of_all() function (ConditionSet, ImageSet: Implement formal Set comprehension #24176) : can't test directly. Doctest ?
• upgrade ax_cxx_compile_stdcxx_11.m4 : I dont't know how to test. Doctest ?
• Your name needs to go in the Authors field.

make ptestlong gives me one (non-transient) failure :

charpent@asus16-ec:/usr/local/sage-8$ sage -t --long src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py
too many failed tests, not using stored timings
Running doctests with ID 2017-11-22-23-04-04-f8ba9318.
Git branch: tst24240_n_24262
Using --optional=database_gap,dot2tex,fricas,giacpy_sage,igraph,mpir,python2,python_igraph,sage
Doctesting 1 file.
sage -t --long src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py
**********************************************************************
File "src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py", line 1652, in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.?
Failed example:
    asy # long time
Expected:
    (4/3*sqrt(3)*sqrt(r)/sqrt(pi) + 47/216*sqrt(3)/(sqrt(pi)*sqrt(r)),
     1, 4/3*sqrt(3)*sqrt(r)/sqrt(pi) + 47/216*sqrt(3)/(sqrt(pi)*sqrt(r)))
Got:
    (4/3*sqrt(3)*sqrt(r)/sqrt(pi) + 191/216*sqrt(3)/(sqrt(pi)*sqrt(r)),
     1,
     4/3*sqrt(3)*sqrt(r)/sqrt(pi) + 191/216*sqrt(3)/(sqrt(pi)*sqrt(r)))
**********************************************************************
File "src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py", line 1655, in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.?
Failed example:
    F.relative_error(asy[0], alpha, [1, 2, 4, 8], asy[1]) # long time
Expected:
    [((3, 3, 2), 0.9812164307, [1.515572606], [-0.54458543...]),
     ((6, 6, 4), 1.576181132, [1.992989399], [-0.26444185...]),
     ((12, 12, 8), 2.485286378, [2.712196351], [-0.091301338...]),
     ((24, 24, 16), 3.700576827, [3.760447895], [-0.016178847...])]
Got:
    [((3, 3, 2), 0.9812164307, [2.167042622], [-1.208526635]),
     ((6, 6, 4), 1.576181132, [2.453648265], [-0.5567045026]),
     ((12, 12, 8), 2.485286378, [3.037931359], [-0.2223667203]),
     ((24, 24, 16), 3.700576827, [3.990777328], [-0.07842034220])]
**********************************************************************
1 item had failures:
   2 of 104 in sage.rings.asymptotic.asymptotics_multivariate_generating_functions.FractionWithFactoredDenominator.?
    [805 tests, 2 failures, 27.28 s]
----------------------------------------------------------------------
sage -t --long src/sage/rings/asymptotic/asymptotics_multivariate_generating_functions.py  # 2 doctests failed
----------------------------------------------------------------------
Total time for all tests: 27.4 seconds
    cpu time: 27.3 seconds
    cumulative wall time: 27.3 seconds

==>needs_work.

[EmmanuelCharpentier]

Reviewer: Emmanuel Charpentier

[rwst]

comment:5

Replying to @EmmanuelCharpentier:

• fix interface to Singular GCD (Doctest improvements to symbolic GCD #23845) : yes. The planned doctest don't seem to have been added.

They are always added in the reporting tickets.

• fix compiler warnings : I still get :

charpent@asus16-ec:~$ cat /usr/local/sage-8/logs/pkgs/pynac-0.7.13.log  | grep warn
/usr/local/sage-8/local/include/flint/fmpz.h:428:23: warning: declaration of 'mpz_ptr' shadows a global declaration [-Wshadow]
/usr/local/sage-8/local/include/flint/fmpz.h:428:23: warning: declaration of 'mpz_ptr' shadows a global declaration [-Wshadow]
/usr/local/sage-8/local/include/flint/fmpz.h:428:23: warning: declaration of 'mpz_ptr' shadows a global declaration [-Wshadow]

They need to be fixed by updating Flint, as I have submitted the fix to Flint some time ago.

• asin/atan enhancements (Some trivial identities and simplifications missed by Sage (pynac ?) #24211) : partial fix :

sage: [arccot(t) for t in [0, 1/sqrt(3), 1, sqrt(3)]] # Partially fixed
[1/2*pi, arccot(1/3*sqrt(3)), 1/4*pi, arccot(sqrt(3))]

Sorry but you didn't report that. Of course I'll add it soon.

The simplifications are not fixed either (but I'm not sure they could be by pynac's upgrade...) :

I have pointed out already that simplify omissions are basically Maxima's.

• set_of_all() function (ConditionSet, ImageSet: Implement formal Set comprehension #24176) : can't test directly. Doctest ?

Well, see #24176.

• upgrade ax_cxx_compile_stdcxx_11.m4 : I dont't know how to test. Doctest ?

This is a Pynac build enhancement.

• Your name needs to go in the Authors field.

Done.

make ptestlong gives me one (non-transient) failure :

What do you mean with "non-transient"? "non-transient using make ptestlong" or "non-transient using sage -t manually"? I cannot reproduce using sage -t on OpenSuSE, so this might be system-specific, or it might be make ptestlong-specific.

[rwst]

Author: Ralf Stephan