Fix perl_term_readline_gnu build error on conda-forge-macos-maximal

[mkoeppe]

https://github.com/mkoeppe/sage/runs/612692498

x86_64-apple-darwin13.4.0-clang -c  -I/Users/runner/runners/2.169.1/work/sage/sage/.tox/local-conda-forge-macos-maximal/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -mmacosx-version-min=10.9 -fno-strict-aliasing -pipe -fstack-protector-strong -DPERL_USE_SAFE_PUTENV -O3   -DVERSION=\"1.35\" -DXS_VERSION=\"1.35\" -fPIC --sysroot=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk "-I/Users/runner/runners/2.169.1/work/sage/sage/.tox/local-conda-forge-macos-maximal/conda/lib/5.26.2/darwin-thread-multi-2level/CORE"  -DHAVE_STRING_H -DTRG_READLINE_VERSION=0x0800 Gnu.c
clang-9: warning: argument unused during compilation: '--sysroot=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk' [-Wunused-command-line-argument]
Gnu.xs:161:8: error: unknown type name 'rl_hook_func_t'
static rl_hook_func_t *rl_pre_input_hook;
       ^
Gnu.xs:164:8: error: unknown type name 'rl_compdisp_func_t'
static rl_compdisp_func_t *rl_completion_display_matches_hook;
       ^

---

References:

• https://perldoc.perl.org/ExtUtils/MakeMaker.html

• Patch is generated from ​https://github.com/mkoeppe/Term-Readline-Gnu.git

CC: @isuruf @saraedum @dimpase

Component: porting

Author: Matthias Koeppe, Isuru Fernando

Branch/Commit: df48845

Reviewer: Isuru Fernando, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29572

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1,13 @@
 https://github.com/mkoeppe/sage/runs/612692498
+
+```
+x86_64-apple-darwin13.4.0-clang -c  -I/Users/runner/runners/2.169.1/work/sage/sage/.tox/local-conda-forge-macos-maximal/local/include -fno-common -DPERL_DARWIN -no-cpp-precomp -mmacosx-version-min=10.9 -fno-strict-aliasing -pipe -fstack-protector-strong -DPERL_USE_SAFE_PUTENV -O3   -DVERSION=\"1.35\" -DXS_VERSION=\"1.35\" -fPIC --sysroot=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk "-I/Users/runner/runners/2.169.1/work/sage/sage/.tox/local-conda-forge-macos-maximal/conda/lib/5.26.2/darwin-thread-multi-2level/CORE"  -DHAVE_STRING_H -DTRG_READLINE_VERSION=0x0800 Gnu.c
+clang-9: warning: argument unused during compilation: '--sysroot=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk' [-Wunused-command-line-argument]
+Gnu.xs:161:8: error: unknown type name 'rl_hook_func_t'
+static rl_hook_func_t *rl_pre_input_hook;
+       ^
+Gnu.xs:164:8: error: unknown type name 'rl_compdisp_func_t'
+static rl_compdisp_func_t *rl_completion_display_matches_hook;
+       ^
+```
+

[isuruf]

comment:2

I'm not sure why it's picking up the readline package from macOS.

[isuruf]

comment:3

I know why. perl_term_readline_gnu is not using CFLAGS env variable

[isuruf]

comment:4

spkg-install.in should pass the path of readline to Makefile.PL using --incpath=

[isuruf]

comment:5

incdir, sorry.

[isuruf]

comment:6

Should have been includedir and libdir

[mkoeppe]

comment:7

I see. Related: #29000

[dimpase]

comment:8

OK, I'm going to fix #29000, creating env vars SAGE_READLINE_INCDIR and
SAGE_READLINE_LIBDIR - it would help if you tell me what needs to change here, like

- perl Makefile.PL --prefix="$SAGE_LOCAL" INSTALL_BASE="$SAGE_LOCAL"
+ perl Makefile.PL --prefix="$SAGE_LOCAL" INSTALL_BASE="$SAGE_LOCAL" \ 
+ --includedir=$SAGE_READLINE_INCDIR --libdir=$SAGE_READLINE_LIBDIR 

Does this look right?

[isuruf]

comment:9

You don't need the prefix there.

perl Makefile.PL --includedir=$SAGE_READLINE_INCDIR --libdir=$SAGE_READLINE_LIBDIR INSTALL_BASE="$SAGE_LOCAL" 

[isuruf]

comment:10

Can you try something like,

--- Makefile.PL 2020-04-27 04:21:25.239877458 +0000
+++ Makefile.PL.old     2020-04-27 04:19:41.682872176 +0000
@@ -138,14 +138,14 @@
      VERSION_FROM => 'Gnu.pm',
      MIN_PERL_VERSION => '5.8.1',
      LIBS        => [ "$RLLIB $libs" ],
-     LDDLFLAGS   => "$RLLIB $Config{lddlflags} $ENV{LDFLAGS}",                                                                                                       
+     LDDLFLAGS   => "$RLLIB $Config{lddlflags}",                                                                                                                     
      dynamic_lib  => { OTHERLDFLAGS => $lddflags },                                                                                                                  
      DEFINE      => $defs,                                                                                                                                           
      ($Config{osname} eq 'os2' ?                                                                                                                                     
       (
        IMPORTS   => { xfree => 'emxlibcm.401' }, # Yuck!
       ) : () ),
-     INC         => "$RLINC $ENV{CFLAGS}",
+     INC         => $RLINC,
      dist        => { COMPRESS => 'gzip -9f', SUFFIX => 'gz' },
      clean       => { FILES => "rlver.c rlver$Config{_exe} rlmalloc.c rlmalloc$Config{_exe}" },
 );

[isuruf]

comment:11

@mkoeppe, can you try the patch above?

[mkoeppe]

comment:12

Thanks, will try

[mkoeppe]

comment:13

Just quickly checked that 1.36 does not contain an immediate fix for the problem (#29623)

[isuruf]

comment:14

That patch should be reversed. Sorry about that.

[mkoeppe]

comment:15

Sure.