coxeter3: Add spkg-configure.m4, use coxeter/ prefix for includes, move OptionalExtension options to .pyx file directives

[mkoeppe]

Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions; they install coxeter in a compatible way, i.e., headers with the prefix coxeter/.

In this ticket we change the includes in src/sage/libs/coxeter3/decl.pxd to use the prefix coxeter/, which allows us to get rid of include_dirs in src/module_list.py:

    OptionalExtension('sage.libs.coxeter3.coxeter',
              sources = ['sage/libs/coxeter3/coxeter.pyx'],
              language="c++",
              include_dirs = [os.path.join(SAGE_INC, 'coxeter')],
              package = 'coxeter3'),

This simplifies the work in #29720.

CC: @tscrim @dimpase @orlitzky @antonio-rojas @isuruf

Component: build: configure

Keywords: sd109

Author: Matthias Koeppe

Branch/Commit: 1497f3f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29721

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
-Package exist on Arch and Fedora according to https://repology.org/project/coxeter/versions
+Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions
 
 It should be checked that all distributions that package the library install the headers with the same prefix `coxeter/`.
 
@@ -14,6 +14,6 @@
 
 It should be checked whether we can get rid of `include_dirs` by changing `src/sage/libs/coxeter3/decl.pxd`.
 
-This would simply the work in #29720.
+This would simplify the work in #29720.
 
 

[mkoeppe]

Branch: u/mkoeppe/spkg_configure_m4_for_coxeter3

[mkoeppe]

New commits:

ad1b8b7

build/pkgs/coxeter3/distros/fedora.txt: New

[mkoeppe]

Commit: ad1b8b7

[mkoeppe]

Changed keywords from none to sd109

[mkoeppe]

comment:5

Help with this ticket would be very welcome

[mkoeppe]

Author: Matthias Koeppe, ...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

3dd2927

src/module_list.py: Move OptionalExtension options for sage.libs.coxeter3.coxeter to distutils directive

[sagetrac-git]

Changed commit from ad1b8b7 to 3dd2927

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

dbbc985

src/sage/libs/coxeter3/decl.pxd: Add coxeter/ prefix to all header includes; src/module_list.py: remove include_dirs option

[sagetrac-git]

Changed commit from 3dd2927 to dbbc985

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,8 +1,6 @@
-Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions
+Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions; they install coxeter in a compatible way, i.e., headers with the prefix `coxeter/`.
 
-It should be checked that all distributions that package the library install the headers with the same prefix `coxeter/`.
-
-Currently we have in `src/module_list.py`:
+In this ticket we change the includes in `src/sage/libs/coxeter3/decl.pxd` to use the prefix `coxeter/`, which allows us to get rid of `include_dirs` in `src/module_list.py`:
 
 ```
     OptionalExtension('sage.libs.coxeter3.coxeter',
@@ -12,8 +10,6 @@
               package = 'coxeter3'),
 ```
 
-It should be checked whether we can get rid of `include_dirs` by changing `src/sage/libs/coxeter3/decl.pxd`.
-
-This would simplify the work in #29720.
+This simplifies the work in #29720.
 
 

[sagetrac-git]

Changed commit from dbbc985 to 1497f3f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6909e23	build/pkgs/coxeter3/distros/fedora.txt: New
2b060ae	src/module_list.py: Move OptionalExtension options for sage.libs.coxeter3.coxeter to distutils directive
4f0d07d	src/sage/libs/coxeter3/decl.pxd: Add coxeter/ prefix to all header includes; src/module_list.py: remove include_dirs option
1497f3f	build/pkgs/coxeter3/spkg-configure.m4: New

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,6 +1,8 @@
 Package exists on Arch and Fedora according to https://repology.org/project/coxeter/versions; they install coxeter in a compatible way, i.e., headers with the prefix `coxeter/`.
 
-In this ticket we change the includes in `src/sage/libs/coxeter3/decl.pxd` to use the prefix `coxeter/`, which allows us to get rid of `include_dirs` in `src/module_list.py`:
+There is no .pc file. We add an `spkg-configure.m4` using `AC_LINK_IFELSE`.
+
+We also change the includes in `src/sage/libs/coxeter3/decl.pxd` to use the prefix `coxeter/`, which allows us to get rid of `include_dirs` in `src/module_list.py`:
 
 ```
     OptionalExtension('sage.libs.coxeter3.coxeter',
@@ -9,7 +11,6 @@
               include_dirs = [os.path.join(SAGE_INC, 'coxeter')],
               package = 'coxeter3'),
 ```
-
-This simplifies the work in #29720.
+(This simplifies the work in #29720.)