Update suitesparse to 5.10.1 to fix build failure with cuda 11

[sagetrac-johan]

Sage 9.1 fails to build with cuda 11, as cuda 11 no longer supports the "architecture" compute_30.

Upstream ticket: DrTimothyAldenDavis/SuiteSparse#56

A fix would be to remove compute_30 from the build commands.

Upstream: Fixed upstream, in a later stable release.

CC: @kiwifb @embray @dimpase @orlitzky @kliem

Component: build

Author: Matthias Koeppe, François Bissey

Branch: f2d21ed

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30478

[mkoeppe]

comment:1

How to replicate the build failure?

[sagetrac-johan]

comment:2

I am not sure what your environment is, but the following is the contents of a small dockerfile to replicate the build failure:

FROM nvidia/cuda:11.0-devel-ubuntu20.04

SHELL ["/bin/bash", "-c"]

ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update && apt-get install --yes build-essential m4 dpkg-dev gettext automake apt-utils git cmake pkg-config python

RUN adduser user < /dev/null

USER user
WORKDIR /home/user/

RUN mkdir Sage && \
    git clone git://git.sagemath.org/sage.git Sage && \
    cd Sage && \
    git checkout 9.1

RUN cd Sage && \
    make -j 4 |& tee build_log.txt || true

After the build, the file /home/user/Sage/logs/pkgs/suitesparse-5.6.0.log contains the following, near the end:

/usr/local/cuda/bin/nvcc -I../../AMD/Include -I../../AMD/Source -I../../COLAMD/Include -I/home/user/Sage/local/var/tmp/sage/build/suitesparse-5.6.0/src/CCOLAMD/Include -I/home/user/Sage/local/var/tmp/sage/build/suitesparse-5.6.0/src/CAMD/Include -I../Include -I../../SuiteSparse_config -I/usr/local/cuda/include/ -Xcompiler -fPIC -O3 -gencode=arch=compute_30,code=sm_30 -gencode=arch=compute_35,code=sm_35 -gencode=arch=compute_50,code=sm_50 -gencode=arch=compute_53,code=sm_53 -gencode=arch=compute_53,code=sm_53 -gencode=arch=compute_60,code=compute_60 -c ../GPU/cholmod_gpu_kernels.cu
nvcc fatal   : Unsupported gpu architecture 'compute_30'

My GPU happens to support compute_60, but the build statement looks very generic, so I assume it might not even matter that I have a GPU, for the purposes of replicating the build failure.

[mkoeppe]

Branch: u/mkoeppe/suitesparse_build_failure_with_cuda_11___sage_9_1_

[mkoeppe]

comment:4

I was able to replicate the build error using tox -e docker-ubuntu-focal-nvidia-cuda-11.0-standard -- suitesparse.

[mkoeppe]

Changed branch from u/mkoeppe/suitesparse_build_failure_with_cuda_11___sage_9_1_ to none

[mkoeppe]

Branch: u/mkoeppe/suitesparse_build_failure_with_cuda_11___sage_9_1_

[mkoeppe]

New commits:

40a47b4

tox.ini: Add nvidia-cuda

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Commit: 40a47b4

[mkoeppe]

comment:7

Someone should prepare a pull request for upstream.

[sagetrac-johan]

comment:8

There was a new commit to upstream pushed to github yesterday, and it seems to have removed references to compute_30 from the build files.

New contents in the file named "ChangeLog" in the commit:

May 17, 2021, SuiteSparse 5.10.1

• CUDA: remove sm_30 from SuiteSparse_config.mk
• GraphBLAS v5.0.5: minor bug fix
• minor changes to Makefiles

A rebuild of Sage with SuiteSparse version 5.10.1, or with its master branch (which is currently probably the same), would be interesting.

[mkoeppe]

comment:10

Looks like we have to wait for an actual release - https://github.com/DrTimothyAldenDavis/SuiteSparse/releases is still at 5.10.0