Deprecate methods arguments (alias: args), number_of_arguments for non-callable symbolic expressions

[mkoeppe]

Follow up from #14270.

We deprecate the use of methods arguments (alias: args) and number_of_arguments on non-callable symbolic expressions.

(previously noted in #9126.)

CC: @orlitzky @egourgoulhon

Component: symbolics

Author: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32227

[mkoeppe]

Branch: u/mkoeppe/noncallable_expression_deprecate_arguments

[mkoeppe]

Commit: d3b62fa

[mkoeppe]

comment:2

This will need adjustments in the plotting code, which seems to use arguments

---

Last 10 new commits:

6492b8c	src/sage/symbolic/ring.pyx: Pass the correct stacklevel to deprecatio()
04fdda6	sage.all: In filterwarnings, remove leading '.*' from module regexes, use regex that matches vendored 'packaging'
a6691b4	Merge #32139
9f5c197	remove function call syntax from symbolic expressions
1735601	SymbolicRing: Update documentation and tests
69a81ca	sage.all: Fix up filterwarnings for collections.abc
fb48800	Merge #32139
98f7af1	src/sage/tests/books/computational-mathematics-with-sagemath/integration_doctest.py: Avoid deprecated use of an expression as a callable
6566e8d	src/sage/combinat/tutorial.py: Remove use of expression call
d3b62fa	Expression: Deprecate arguments, args, number_of_arguments for non-callable expressions

[saliola]

comment:4

I just noticed that the docstring for __len__ in expression.pyx says it returns the number of arguments of the expression, but it really should say number of operands since that is what is actually returned. I guess it would make sense to correct the docstring on this ticket.

[mkoeppe]

comment:5

Let's make this change in #29738, which deprecates the __len__ method

[mkoeppe]

Changed dependencies from #14270 to #14270, #32234

[mkoeppe]

Changed dependencies from #14270, #32234 to #14270, #29738, #32234

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,4 +1,4 @@
 Follow up from #14270.
 
-We deprecate the use of methods `arguments` (alias: `args`) and `number_of_arguments` on non-callable symbolic expressions, as well as `_fast_callable_`.
+We deprecate the use of methods `arguments` (alias: `args`) and `number_of_arguments` on non-callable symbolic expressions, and perhaps also `_fast_callable_`.
 

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

9199406	src/sage/plot/plot3d/parametric_surface.pyx: Remove handling of FastDoubleFunc
e6f88d6	src/sage/ext/fast_eval.pyx: Reduce/update documentation
1353baf	Trac #32234: use fast_callable() for symbolic find_root().
c56fa05	Trac #32234: don't import fast_callable() from sage.ext.fast_eval.
0fcec8e	Trac #32234: replace fast_float_arg() in plot3d.
1479666	Trac #32234: fix symbolic find_local_minimum() docs.
19aa975	Trac #32234: use domain=float for fast callables used by numpy.
df062b3	Trac #32234: replace two trivial fast-callables in plot3d().
a4c840d	Merge tag '9.4.rc2' into t/32234/ticket/32234
986fc2e	Merge #32234

[sagetrac-git]

Changed commit from d3b62fa to 986fc2e

[mkoeppe]

Changed dependencies from #14270, #29738, #32234 to #14270, #32234

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

comment:12

Setting to needs_review only to run the patchbot

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,3 +2,5 @@
 
 We deprecate the use of methods `arguments` (alias: `args`) and `number_of_arguments` on non-callable symbolic expressions, and perhaps also `_fast_callable_`.
 
+(previously noted in #9126.)
+

[sagetrac-git]

Changed commit from 986fc2e to 57ef44d