sage.rings.abc: Add pAdicRing, pAdicField; deprecate is_pAdic...

[mkoeppe]

This change will allow use to eliminate imports from sage.rings.padics in sage.rings.polynomial.polynomial_element.

Part of Meta-ticket #32414.

Depends on #32665

CC: @EnderWannabe @bhutz

Component: refactoring

Author: Matthias Koeppe, Alexander Galarraga

Branch/Commit: 03b24bd

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/32750

[mkoeppe]

Branch: u/mkoeppe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___

[sagetrac-git]

Commit: e1412c7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1893620	src/sage/dynamics/arithmetic_dynamics/projective_ds.py: Use sage.rings.abc.pAdicRing, pAdicField
8422015	src/sage/modular/overconvergent/genus0.py: Use sage.rings.abc.pAdicField
c32b3a2	src/sage/schemes/berkovich: Use sage.rings.abc.pAdicField
96a778b	src/sage/schemes/elliptic_curves/constructor.py: Use sage.rings.abc.pAdicField
b672836	src/sage/schemes/hyperelliptic_curves: Use sage.rings.abc.pAdicField
e1412c7	src/sage/schemes/projective/projective_morphism.py: Use sage.rings.abc.pAdicField

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,2 +1,4 @@
-This change will allow use to eliminate the imports from `sage.rings.padics` in `sage.rings.polynomial.polynomial_element`
+This change will allow use to eliminate imports from `sage.rings.padics` in `sage.rings.polynomial.polynomial_element`.
 
+Part of Meta-ticket #32414.
+

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Changed commit from e1412c7 to fc7025a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fc7025a

src/sage/rings/padics/generic_nodes.py: Update doctests with deprecation warning output

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

070d05b

src/sage/schemes/projective/projective_morphism.py: Avoid merge conflict

[sagetrac-git]

Changed commit from fc7025a to 070d05b

[EnderWannabe]

Changed branch from u/mkoeppe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___ to u/gh-EnderWannabe/sage_rings_abc__add_padicring__padicfield__deprecate_is_padic___

[EnderWannabe]

Changed commit from 070d05b to 59271be

[EnderWannabe]

comment:7

Added missing imports in src/sage/modular/overconvergent/genus0.py and src/sage/schemes/hyperelliptic_curves/constructor.py. Hopefully this passes patchbot now; the rest of the changes looked good to me.

---

New commits:

59271be

32750: added missing imports

[mkoeppe]

comment:8

Thanks for fixing this!

[mkoeppe]

comment:9

The remaining failure, from src/sage/rings/integer.pyx, is not from this ticket. It is fixed in #32737.

[kliem]

comment:10

pyflakes detects that the import from sage.rings.ring import EuclideanDomain, Field in generic_nodes.py can probably be removed now.