sage_setup: Add missing dependency

[mkoeppe]

This is blocking the creation of sdists for PyPI

https://github.com/sagemath/sage/runs/6849918030?check_suite_focus=true

 File "/home/runner/work/sage/sage/local/var/lib/sage/venv-python3.8/lib/python3.8/site-packages/sage_setup/autogen/interpreters/utils.py", line 19, in <module>
    from jinja2 import Environment
ModuleNotFoundError: No module named 'jinja2'

CC: @kiwifb

Component: build

Author: Matthias Koeppe

Branch: 1176758

Reviewer: François Bissey

Issue created by migration from https://trac.sagemath.org/ticket/33983

[mkoeppe]

Branch: u/mkoeppe/sage_setup__add_missing_dependency

[mkoeppe]

Commit: d490b8f

[mkoeppe]

New commits:

d490b8f

build/pkgs/sage_setup/dependencies: Add jinja2

[mkoeppe]

Author: Matthias Koeppe

[kiwifb]

comment:3

I'll say that's damning evidence. I did a quick inspection to see if something else obvious was missing but I couldn't find anything. Shouldn't it also be in requirements.txt and setup.cfg? Especially if it blocks stuff on Pypi, I would expect those to be looked at rather than dependencies which is a sage build system artifact not a pure python one.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1176758

pkgs/sage-setup: Add jinja2 dep to requirements.txt, setup.cfg

[sagetrac-git]

Changed commit from d490b8f to 1176758

[mkoeppe]

comment:5

Replying to @kiwifb:

Shouldn't it also be in requirements.txt and setup.cfg?

Indeed. Thanks!

Especially if it blocks stuff on Pypi, I would expect those to be looked at rather than dependencies which is a sage build system artifact not a pure python one.

We do build our sdists for PyPI by going through the Sage build system

[kiwifb]

Reviewer: François Bissey

[kiwifb]

comment:6

LGTM. Glad that I put a little bit more thought in that review.

[mkoeppe]

comment:7

Thanks!

[vbraun]

Changed branch from u/mkoeppe/sage_setup__add_missing_dependency to 1176758